Skip to content

refactor(core): use canonical provider identifiers #1022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edelauna merged 6 commits into from
Jul 26, 2026
Merged

refactor(core): use canonical provider identifiers #1022

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2ae31c2
refactor(core): use canonical provider identifiers
WebMad Jul 25, 2026
53a2fdd
test(core): tighten canonical provider coverage
WebMad Jul 25, 2026
0e23a5a
test(core): avoid mutating provider identifiers
WebMad Jul 25, 2026
1038c38
test(core): address canonical identifier review feedback
WebMad Jul 26, 2026
d2f0931
chore(lint): update test suppression counts
WebMad Jul 26, 2026
14a8974
test(core): keep existing non-null assertions
WebMad Jul 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/core/task/Task.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ import {
ConsecutiveMistakeError,
MAX_MCP_TOOLS_THRESHOLD,
countEnabledMcpTools,
providerIdentifiers,
} from "@roo-code/types"
import { TelemetryService } from "@roo-code/telemetry"
import { CloudService } from "@roo-code/cloud"
Expand Down Expand Up @@ -4220,7 +4221,7 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
// but uses allowedFunctionNames to restrict which tools can be called.
// Other providers (Anthropic, OpenAI, etc.) don't support this feature yet,
// so they continue to receive only the filtered tools for the current mode.
const supportsAllowedFunctionNames = apiConfiguration?.apiProvider === "gemini"
const supportsAllowedFunctionNames = apiConfiguration?.apiProvider === providerIdentifiers.gemini

{
const provider = this.providerRef.deref()
Expand Down
Loading
Loading