[Improve] Harden DCG binary installation - #1060
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
5c460bd to
baade5f
Compare
edelauna
left a comment
There was a problem hiding this comment.
Looks good - just had 2 comments for increased test coverage.
baade5f to
e1a0c39
Compare
edelauna
left a comment
There was a problem hiding this comment.
😅 have a couple additional comments related to the logic used for the guard.
edelauna
left a comment
There was a problem hiding this comment.
Looks good - approving with some minor nits, which could also always be addressed later if we want.
|
Addressed all current unresolved review feedback in 5f3854a. DCG now preserves |
What changed
Completes the DCG binary-service safeguards with macOS temporary-directory support, an explicit skipped ZIP-only test on non-Windows CI, and coverage for trusted cross-host GitHub release redirects.
Why this change was made
DCG must run with the minimum viable environment and install predictably across supported platforms and GitHub's release-asset redirect flow. Closes #1056.
Impact
DCG installation and execution are more reliable across platforms while keeping extension-host secrets out of the child process environment.
Related PRs