[Refactor] Roll out stream helpers to Requesty spec - #1089
Merged
Conversation
Contributor
Author
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
edelauna
marked this pull request as ready for review
August 1, 2026 13:42
edelauna
requested review from
JamesRobert20,
edelauna,
hannesrudolph,
navedmerchant and
taltas
as code owners
August 1, 2026 13:42
edelauna
approved these changes
Aug 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
src/test-utils/__tests__/stream.spec.tsto cover ordered collection, empty streams, and error propagation for the shared stream helpers.src/api/providers/__tests__/requesty.spec.tsto replace inline async-iterator mock streams withasyncStreamFromand pure collect-then-assert loops withcollectStream.requesty.spec.tsESLint suppressions entry after its explicit-anysuppressions dropped to zero.Why this change was made
This continues the approved test-utils rollout now that the initial async-stream helper pilot has merged. It broadens the pattern to another provider spec while keeping partial-consumption generator tests inline where stepwise control is the point.
Impact
No user-facing behavior change. The shared helper is now directly tested, another provider spec is easier to maintain, and targeted tests, src lint/typecheck, and the full Zoo-Code test suite passed.
Related PRs