[Refactor] Roll out stream helpers to Anthropic Vertex spec - #1094
Merged
edelauna merged 2 commits intoAug 1, 2026
Conversation
Contributor
Author
|
1 issue outstanding. See task
Reviewed 5a7f681 |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
Author
|
Addressed the outstanding review finding in
|
edelauna
approved these changes
Aug 1, 2026
edelauna
marked this pull request as ready for review
August 1, 2026 20:13
edelauna
requested review from
JamesRobert20,
hannesrudolph,
navedmerchant and
taltas
as code owners
August 1, 2026 20:13
edelauna
enabled auto-merge
August 1, 2026 20:13
edelauna
deleted the
refactor/large-provider-stream-test-utils-06q4nypl2c73c
branch
August 1, 2026 20:30
This was referenced Aug 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
anthropic-vertex.spec.tsto the shared stream helpers.for (const chunk of mockStream) yield chunkiterators, direct-yield stream mocks, and default streaming mocks withasyncStreamFrom.collectStream, including the rejection-drain assertion.ApiStreamChunkimport after the migration.Why this change was made
This is the more ambitious continuation of the approved test-utils rollout: one of the largest remaining provider-spec stream-mock files, cleared in a single focused PR.
Impact
No user-facing behavior change. The 44-test Anthropic Vertex spec now uses the shared stream-helper idiom, targeted tests passed, src lint/typecheck passed, and the full Zoo-Code test suite passed.
Related PRs