[Refactor] Roll out stream helpers to LiteLLM and Z.ai specs - #1095
Merged
Conversation
Contributor
Author
|
No code issues found. See task
Reviewed 838d3fb |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
Author
|
Addressed both outstanding review findings.
|
edelauna
marked this pull request as ready for review
August 1, 2026 21:00
edelauna
requested review from
JamesRobert20,
edelauna,
hannesrudolph,
navedmerchant and
taltas
as code owners
August 1, 2026 21:00
edelauna
approved these changes
Aug 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
lite-llm.spec.tsto the shared stream helpers, replacing all inline async-iterator mock streams withasyncStreamFromand all pure result/drain loops withcollectStream.zai.spec.tsto the same helpers, replacing custom[Symbol.asyncIterator]next-chain mocks withasyncStreamFrom.makeMockStream()factories so each test gets an unconsumed generator.collectStreamimport fromzai.spec.ts.Why this change was made
This is the more ambitious continuation of the approved test-utils rollout: two high-count provider specs migrated in one PR while keeping single-chunk
.next()assertions inline where they are the point of the test.Impact
No user-facing behavior change. Eighty-one targeted provider tests passed, src lint/typecheck passed, and the full Zoo-Code test suite passed.
Related PRs