[Refactor] Roll out stream helpers to Qwen, LM Studio, and Fireworks specs - #1103
Merged
edelauna merged 1 commit intoAug 2, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
edelauna
approved these changes
Aug 2, 2026
edelauna
marked this pull request as ready for review
August 2, 2026 18:03
edelauna
requested review from
JamesRobert20,
hannesrudolph,
navedmerchant and
taltas
as code owners
August 2, 2026 18:03
edelauna
enabled auto-merge
August 2, 2026 18:03
edelauna
deleted the
refactor/qwen-lmstudio-fireworks-stream-utils-06q4nypl2c73c
branch
August 2, 2026 18:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
qwen-code-native-tools.spec.ts,lmstudio-native-tools.spec.ts, andfireworks.spec.tsto the shared stream helpers.asyncStreamFrom, including empty done-true mocks.collectStreamwhile leaving side-effectNativeToolCallParserloops inline.qwen-code-native-tools.spec.tsESLint suppressions count from 5 to 2.Why this change was made
This continues the approved test-utils rollout with another three-file batch, broadening the shared stream-helper idiom while preserving request-shape, first-chunk, and tool-call parser assertions.
Impact
No user-facing behavior change. Fifty targeted provider tests passed, src lint/typecheck passed, and the full Zoo-Code test suite passed.
Related PRs