Skip to content

Fix:Comments in .py files#30

Open
SahanChan wants to merge 1 commit intoa1studmuffin:masterfrom
SahanChan:master
Open

Fix:Comments in .py files#30
SahanChan wants to merge 1 commit intoa1studmuffin:masterfrom
SahanChan:master

Conversation

@SahanChan
Copy link
Copy Markdown

Gave some life to the python code by adding comments.
;-)

@zircher
Copy link
Copy Markdown

zircher commented Oct 27, 2019

Just curious, has this been tested under 2.8?

@SahanChan
Copy link
Copy Markdown
Author

Just curious, has this been tested under 2.8?

Yeah, it is tested, they are just comments.
XD

@ldo
Copy link
Copy Markdown

ldo commented Jan 20, 2022

My policy with comments is they should explain why you are doing something, rather than simply repeating what the code is doing.

For example, from my version:

def define_tex_coords_common() :
    # creates a node group that defines a common coordinate system
    # for all my image textures.
    ...

def define_hull_colour_common() :
    # creates a node group that applies the grunge factor to
    # an input colour to produce an output colour.
    ...

def define_normals_common() :
    # defines a node group for the normal-mapping texture to be used
    # across different hull materials.
    ...

etc, etc.

@SahanChan
Copy link
Copy Markdown
Author

Yup you are right :))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants