chore: migrate clustermode/examples to use generic pull queue#363
chore: migrate clustermode/examples to use generic pull queue#363nahapetyan-serob wants to merge 5 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request replaces the custom database event queue manager with a pull-based queue manager using a new dbPuller implementation in the cluster mode example. It also updates the Dockerfile to Go 1.25, improves error handling in the client streaming logic, and ensures optimistic concurrency failures wrap taskstore.ErrConcurrentModification. The review feedback suggests several improvements: ignoring stream errors if a terminal event has already been received, returning an error instead of silently continuing if scanning database rows fails, and checking rows.Err() after iterating through database rows to prevent premature termination issues.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This PR migrates the
examples/clustermodeserver from its DB-backed event queue to the generic pull event queue introduced in #354.New
puller.go: implementseventqueue.PullerDeleted
eventqueue.go: replaced by the generic pull manager.client/main.go: on SSE stream error duringsend, fall through tosubscribe(taskID)so the client resumes after transient drops.Dockerfile.app: bump Go 1.24 → 1.25 and adjust build paths for the example's module layout.The puller tolerates
ErrTaskNotFoundon the initial snapshot and returns a syntheticTASK_STATE_SUBMITTEDplaceholder, handling the race where the frontend creates the reader before the backend worker has inserted the initial task row. `