chore(timestamp): python sample A2A 1.0.3 update#624
Conversation
There was a problem hiding this comment.
Code Review
This pull request restructures the Python Timestamp Extension showcase by modularizing the codebase into separate core, client, and server modules, updating the documentation, and adding integration tests. The review feedback identifies several critical issues: Python 3.10 compatibility is broken by using datetime.UTC instead of datetime.timezone.utc in both the core logic and tests; the integration tests risk hanging indefinitely due to unread subprocess pipes and a lack of timeout during process termination; and the README contains a documentation error where ClientFactory is instantiated with an incorrect parameter name.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
c23e8d9 to
eb643bc
Compare
Refactor: Update timestamp extension to a2a-sdk v1.0.3 and migrate to pip
Overview
This PR refactors the
timestampextension sample to align it with the stablea2a-sdk v1.0.3API specification, improves internal naming conventions for better readability, and transitions the project's dependency management fromuvto standardpipandrequirements.txt.Key Changes
1. Project Layout Re-organization
src/timestamp_ext/package (containingclient.py,core.py, andserver.py).tests/directory (containing__main__.pyandtest_client.py).2. Upgrade to
a2a-sdk v1.0.3Stable APIa2a.types.a2a_pb2anda2a.helpers.proto_helpers) to the clean, stablea2a.typesanda2a.helpersfacades across all source and test files.TransportProtocol.JSONRPCenum references with standard string literals ('JSONRPC') directly inAgentInterfacesetup.pyproject.tomlversion constraint to targeta2a-sdk>=1.0.3.3. Dependency Management Transition ($\rightarrow$
uvpip)requirements.txt: Generated a fully resolved and pinnedrequirements.txtfrompyproject.tomlusinguv pip compileto support standardpip installenvironments.uv.lockfile.4. Readability & Explicit Naming
delegatevariables, parameters, and fields to highly explicit, self-documenting names for better architecture visibility:delegatedelegate_client(in_TimestampingClient)delegatedelegate_client_factory(in_TimestampingClientFactory)delegatedelegate_agent_executor(in_TimestampingAgentExecutor)delegatedelegate_event_queue(in_TimestampingEventQueue)