-
Notifications
You must be signed in to change notification settings - Fork 1.2k
test(parser): add unit tests for payload_fixer module #1468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vishnuprakaz
wants to merge
4
commits into
a2ui-project:main
Choose a base branch
from
vishnuprakaz:feature/add-payload-fixer-tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+93
−0
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
f504ffd
test(parser): add unit tests for payload_fixer module
vishnuprakaz ef42fbe
test(parser): address review feedback on payload_fixer tests
vishnuprakaz fb99a45
Merge branch 'main' into feature/add-payload-fixer-tests
vishnuprakaz b116ef9
Merge branch 'main' into feature/add-payload-fixer-tests
vishnuprakaz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,93 @@ | ||
| # Copyright 2026 Google LLC | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # https://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| import logging | ||
|
|
||
| import pytest | ||
|
|
||
| from a2ui.parser.payload_fixer import parse_and_fix | ||
|
|
||
|
|
||
| @pytest.mark.parametrize( | ||
| "payload,expected", | ||
| [ | ||
| ( | ||
| '[{"beginRendering": {"surfaceId": "s1", "root": "r1"}}]', | ||
| [{"beginRendering": {"surfaceId": "s1", "root": "r1"}}], | ||
| ), | ||
| ( | ||
| '{"beginRendering": {"surfaceId": "s1", "root": "r1"}}', | ||
| [{"beginRendering": {"surfaceId": "s1", "root": "r1"}}], | ||
| ), | ||
| ("{\u201ckey\u201d: \u201cvalue\u201d}", [{"key": "value"}]), | ||
| ('{"text": "it\u2019s fine"}', [{"text": "it's fine"}]), | ||
| ("[]", []), | ||
| ], | ||
| ) | ||
| def test_parse_and_fix_normalization(payload, expected): | ||
| assert parse_and_fix(payload) == expected | ||
|
|
||
|
|
||
| @pytest.mark.parametrize( | ||
| "payload,expected", | ||
| [ | ||
| ('[{"key": "value",}]', [{"key": "value"}]), | ||
| ('[{"items": ["a", "b",]}]', [{"items": ["a", "b"]}]), | ||
| ('[{"a": 1, "b": [1, 2,]}]', [{"a": 1, "b": [1, 2]}]), | ||
| ('{"a": {"b": 1,}}', [{"a": {"b": 1}}]), | ||
| ('[{"a": [1, 2, 3,]}]', [{"a": [1, 2, 3]}]), | ||
| ], | ||
| ) | ||
| def test_parse_and_fix_trailing_comma(payload, expected): | ||
| assert parse_and_fix(payload) == expected | ||
|
|
||
|
|
||
| def test_parse_and_fix_multiple_messages(): | ||
| payload = ( | ||
| '[{"beginRendering": {"surfaceId": "s1", "root": "r1"}}, {"surfaceUpdate":' | ||
| ' {"surfaceId": "s1", "components": []}}]' | ||
| ) | ||
| result = parse_and_fix(payload) | ||
| assert len(result) == 2 | ||
| assert "beginRendering" in result[0] | ||
| assert "surfaceUpdate" in result[1] | ||
|
|
||
|
|
||
| def test_parse_and_fix_logs_warnings_on_trailing_comma_autofix(caplog): | ||
| payload = '[{"key": "value",}]' | ||
| with caplog.at_level(logging.WARNING, logger="a2ui.parser.payload_fixer"): | ||
| result = parse_and_fix(payload) | ||
| log_messages = [r.message for r in caplog.records] | ||
| assert any("Initial A2UI payload validation failed" in msg for msg in log_messages) | ||
| assert any( | ||
| "Detected trailing commas in LLM output; applied autofix." in msg | ||
| for msg in log_messages | ||
| ) | ||
| assert result == [{"key": "value"}] | ||
|
|
||
|
|
||
| @pytest.mark.parametrize( | ||
| "payload", | ||
| [ | ||
| "this is not json at all", | ||
| "", | ||
| "{", | ||
| "[", | ||
| '{"key": "value"', | ||
| '[{"key": "value",]', | ||
| ], | ||
| ) | ||
| def test_parse_and_fix_invalid_payload_raises_value_error(payload): | ||
| with pytest.raises(ValueError, match="Failed to parse JSON"): | ||
| parse_and_fix(payload) | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.