Skip to content

fix: make Getting Started work for Mac OS#1515

Open
Yorko wants to merge 2 commits into
a2ui-project:mainfrom
Yorko:fix/issue950_fix_app_macosx
Open

fix: make Getting Started work for Mac OS#1515
Yorko wants to merge 2 commits into
a2ui-project:mainfrom
Yorko:fix/issue950_fix_app_macosx

Conversation

@Yorko
Copy link
Copy Markdown

@Yorko Yorko commented Jun 2, 2026

Description

Before: Both Getting Started guides fail on macOS (Quickstart + README)

After: The guides work.

Examples:

"Find Italian restaurants near me"
image

"What are your hours?
image

The cause

By default, when TypeScript doesn't have an explicit list of types defined in samples/client/lit/shell/tsconfig.json, it scans all node_modules/@types directories up the file tree to automatically include all implicit type definitions.

If there are incomplete, missing, or broken type packages (like @types/retry or @types/trusted-types) in any parent node_modules folders (often created by other tools, parent workspaces, or global settings), TypeScript will throw TS2688 errors.

The Fix
Adding the "types": ["node"] option to the compilerOptions inside samples/client/lit/shell/tsconfig.json

Fixes #950

Pre-launch Checklist

If you need help, consider asking for advice on the discussion board.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds Node.js types to the tsconfig.json of a client-side Lit application. The reviewer correctly noted that including Node.js types in a browser-based environment is unnecessary and can lead to global namespace pollution and type conflicts with standard web APIs. They suggested using an empty array instead to prevent these issues.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread samples/client/lit/shell/tsconfig.json Outdated
This works as well

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Both Getting Started guides fail on macOS (Quickstart + README)

1 participant