fix: make Getting Started work for Mac OS#1515
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds Node.js types to the tsconfig.json of a client-side Lit application. The reviewer correctly noted that including Node.js types in a browser-based environment is unnecessary and can lead to global namespace pollution and type conflicts with standard web APIs. They suggested using an empty array instead to prevent these issues.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This works as well Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
Adding the |
|
Adding the |
1 similar comment
|
Adding the |
github-actions
Bot
added
the
status: needs-triage
2 participants
Description
Before: Both Getting Started guides fail on macOS (Quickstart + README)
After: The guides work.
Examples:
"Find Italian restaurants near me"
"What are your hours?
The cause
By default, when TypeScript doesn't have an explicit list of types defined in
samples/client/lit/shell/tsconfig.json, it scans all node_modules/@types directories up the file tree to automatically include all implicit type definitions.If there are incomplete, missing, or broken type packages (like @types/retry or @types/trusted-types) in any parent node_modules folders (often created by other tools, parent workspaces, or global settings), TypeScript will throw TS2688 errors.
The Fix
Adding the "types": ["node"] option to the
compilerOptionsinsidesamples/client/lit/shell/tsconfig.jsonFixes #950
Pre-launch Checklist
If you need help, consider asking for advice on the discussion board.