fix: make Getting Started work for Mac OS#1515
Open
Yorko wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds Node.js types to the tsconfig.json of a client-side Lit application. The reviewer correctly noted that including Node.js types in a browser-based environment is unnecessary and can lead to global namespace pollution and type conflicts with standard web APIs. They suggested using an empty array instead to prevent these issues.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This works as well Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Before: Both Getting Started guides fail on macOS (Quickstart + README)
After: The guides work.
Examples:
"Find Italian restaurants near me"

"What are your hours?

The cause
By default, when TypeScript doesn't have an explicit list of types defined in
samples/client/lit/shell/tsconfig.json, it scans all node_modules/@types directories up the file tree to automatically include all implicit type definitions.If there are incomplete, missing, or broken type packages (like @types/retry or @types/trusted-types) in any parent node_modules folders (often created by other tools, parent workspaces, or global settings), TypeScript will throw TS2688 errors.
The Fix
Adding the "types": ["node"] option to the
compilerOptionsinsidesamples/client/lit/shell/tsconfig.jsonFixes #950
Pre-launch Checklist
If you need help, consider asking for advice on the discussion board.