refactor: update SDK path references to a2ui_agent subdirectory across samples, CI, and scripts#1521
refactor: update SDK path references to a2ui_agent subdirectory across samples, CI, and scripts#1521nan-yu wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request restructures the repository by moving the Python SDK into a subdirectory (agent_sdks/python/a2ui_agent). This change requires updating conformance test paths, formatting scripts, and dependency references in pyproject.toml and uv.lock files across various samples and evaluation tools. The feedback suggests a best practice improvement in scripts/fix_format.sh to handle potential failures of the cd command by appending || exit 1 to prevent subsequent commands from executing in the wrong directory.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
|
||
| echo "Running Pyink for Python SDK..." | ||
| cd "$REPO_ROOT/agent_sdks/python" | ||
| cd "$REPO_ROOT/agent_sdks/python/a2ui_agent" |
There was a problem hiding this comment.
It is a best practice to handle potential failures of the cd command in shell scripts. If the directory does not exist or cannot be accessed, the script will continue executing subsequent commands (such as uv run pyink) in the wrong directory, which can lead to unexpected behavior or formatting the wrong files. Appending || exit 1 ensures the script terminates immediately if the directory change fails.
| cd "$REPO_ROOT/agent_sdks/python/a2ui_agent" | |
| cd "$REPO_ROOT/agent_sdks/python/a2ui_agent" || exit 1 |
…s samples, CI, and scripts
No description provided.