Skip to content

refactor: update SDK path references to a2ui_agent subdirectory across samples, CI, and scripts#1521

Draft
nan-yu wants to merge 1 commit into
a2ui-project:mainfrom
nan-yu:re-architecture
Draft

refactor: update SDK path references to a2ui_agent subdirectory across samples, CI, and scripts#1521
nan-yu wants to merge 1 commit into
a2ui-project:mainfrom
nan-yu:re-architecture

Conversation

@nan-yu
Copy link
Copy Markdown
Collaborator

@nan-yu nan-yu commented Jun 2, 2026

No description provided.

@github-project-automation github-project-automation Bot moved this to Todo in A2UI Jun 2, 2026
@nan-yu nan-yu marked this pull request as draft June 2, 2026 22:50
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request restructures the repository by moving the Python SDK into a subdirectory (agent_sdks/python/a2ui_agent). This change requires updating conformance test paths, formatting scripts, and dependency references in pyproject.toml and uv.lock files across various samples and evaluation tools. The feedback suggests a best practice improvement in scripts/fix_format.sh to handle potential failures of the cd command by appending || exit 1 to prevent subsequent commands from executing in the wrong directory.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread scripts/fix_format.sh

echo "Running Pyink for Python SDK..."
cd "$REPO_ROOT/agent_sdks/python"
cd "$REPO_ROOT/agent_sdks/python/a2ui_agent"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

It is a best practice to handle potential failures of the cd command in shell scripts. If the directory does not exist or cannot be accessed, the script will continue executing subsequent commands (such as uv run pyink) in the wrong directory, which can lead to unexpected behavior or formatting the wrong files. Appending || exit 1 ensures the script terminates immediately if the directory change fails.

Suggested change
cd "$REPO_ROOT/agent_sdks/python/a2ui_agent"
cd "$REPO_ROOT/agent_sdks/python/a2ui_agent" || exit 1

@nan-yu nan-yu force-pushed the re-architecture branch from 936cc2e to 0d8b3d8 Compare June 2, 2026 22:53
@nan-yu nan-yu force-pushed the re-architecture branch from 0d8b3d8 to 8dcb56d Compare June 2, 2026 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant