Fix streaming top-level objects without list wrapping#1541
Open
selamw1 wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the streaming parser to support parsing single and multiple top-level JSON objects without array wrapping, and adds corresponding unit tests. Feedback suggests simplifying a redundant boolean condition in the parser logic to improve readability, and keeping the validator enabled in the new tests to maintain realistic test coverage.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A2UI v0.9 streams use consecutive top-level JSON objects (JSON Lines format) instead of wrapping them in a top-level array
[...]. Previously,A2uiStreamParserskipped every character until it saw a[bracket, causing all v0.9 blocks to be silently discarded.Fixes #1527
This PR refactors the streaming parser's guard to use a fall-through design:
{when brace count is 0) directly.test_streaming_v09.pyto ensure single and consecutive top-level objects are parsed successfully without list wrapping.Pre-launch Checklist