Skip to content

fix(samples): read restaurant data as utf-8#1926

Open
gaoachao wants to merge 1 commit into
a2ui-project:mainfrom
gaoachao:p/gcc/fix-restaurant-data-encoding-pr
Open

fix(samples): read restaurant data as utf-8#1926
gaoachao wants to merge 1 commit into
a2ui-project:mainfrom
gaoachao:p/gcc/fix-restaurant-data-encoding-pr

Conversation

@gaoachao

@gaoachao gaoachao commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Close #1451

Summary

  • Read the restaurant finder sample data with explicit UTF-8 encoding.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the get_restaurants function in samples/agent/adk/restaurant_finder/tools.py to explicitly specify UTF-8 encoding when opening the restaurant_data.json file, ensuring consistent file reading across different platforms. There are no review comments, so I have no feedback to provide.

@github-actions github-actions Bot added the status: needs-triage auto-managed: https://github.com/a2ui-project/a2ui/blob/main/scripts/triage.mjs label Jul 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: needs-triage auto-managed: https://github.com/a2ui-project/a2ui/blob/main/scripts/triage.mjs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UnicodeDecodeError on Windows when running restaurant_finder sample due to default GBK encoding

1 participant