fix(@a2ui/markdown-it): widen web_core peer dep to >=0.9.2#1931
Open
eugenelim wants to merge 1 commit into
Open
fix(@a2ui/markdown-it): widen web_core peer dep to >=0.9.2#1931eugenelim wants to merge 1 commit into
eugenelim wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the package.json for @a2ui/markdown-it, bumping the version to 0.0.5 and changing the peer dependency of @a2ui/web_core from workspace:* to >=0.9.2. There are no review comments, and I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1930.
@a2ui/markdown-it@0.0.4was published whenweb_corewas at0.9.2, soprepare-publish.mjsbaked in^0.9.2as the peer dep. Since thenweb_coreshipped0.10.x, and any project that pulls in@a2ui/react@^0.10alongside@a2ui/web_core@^0.10gets anERESOLVEoverride warning on every install:The fix: change
peerDependencies["@a2ui/web_core"]fromworkspace:*(whichprepare-publish.mjsresolves to^<current-version>at publish time) to an explicit>=0.9.2. This bypasses the workspace replacement and produces a wide range in the published package — no more peer conflict whenweb_corebumps again. Bumps to0.0.5.The
devDependenciesentry is left asworkspace:*so local builds continue to use the monorepo copy.