fix #202#203
Open
prakash-patel wants to merge 1 commit into
Open
Conversation
aborkowski
reviewed
Dec 16, 2019
aborkowski
left a comment
aborkowski
left a comment
There was a problem hiding this comment.
I would suggest to reject this pull request.
Comment on lines
-204
to
+217
| ownerDocument.createDocumentFragment = Function('h,f', 'return function(){' + | ||
| 'var n=f.cloneNode(),c=n.createElement;' + | ||
| 'h.shivMethods&&(' + | ||
| // unroll the `createElement` calls | ||
| getElements().join().replace(/[\w\-:]+/g, function(nodeName) { | ||
| data.createElem(nodeName); | ||
| data.frag.createElement(nodeName); | ||
| return 'c("' + nodeName + '")'; | ||
| }) + | ||
| ');return n}' | ||
| )(html5, data.frag); | ||
| ownerDocument.createDocumentFragment = function(h,f){ | ||
| return function(){ | ||
| var n=f.cloneNode(),c=n.createElement; | ||
| h.shivMethods&&( | ||
| // unroll the `createElement` calls | ||
| getElements().join().replace(/[\w\-:]+/g, function(nodeName) { | ||
| data.createElem(nodeName); | ||
| data.frag.createElement(nodeName); | ||
| return c("' + nodeName + '"); | ||
| }) | ||
| ); | ||
| return n; | ||
| }; | ||
| }(html5, data.frag); |
There was a problem hiding this comment.
There is no caching or memoization as in the previous and current versions of the function.
Comment on lines
-204
to
+217
| ownerDocument.createDocumentFragment = Function('h,f', 'return function(){' + | ||
| 'var n=f.cloneNode(),c=n.createElement;' + | ||
| 'h.shivMethods&&(' + | ||
| // unroll the `createElement` calls | ||
| getElements().join().replace(/[\w\-:]+/g, function(nodeName) { | ||
| data.createElem(nodeName); | ||
| data.frag.createElement(nodeName); | ||
| return 'c("' + nodeName + '")'; | ||
| }) + | ||
| ');return n}' | ||
| )(html5, data.frag); | ||
| ownerDocument.createDocumentFragment = function(h,f){ | ||
| return function(){ | ||
| var n=f.cloneNode(),c=n.createElement; | ||
| h.shivMethods&&( | ||
| // unroll the `createElement` calls | ||
| getElements().join().replace(/[\w\-:]+/g, function(nodeName) { | ||
| data.createElem(nodeName); | ||
| data.frag.createElement(nodeName); | ||
| return c("' + nodeName + '"); | ||
| }) | ||
| ); | ||
| return n; | ||
| }; | ||
| }(html5, data.frag); |
There was a problem hiding this comment.
There is no caching or memoization as in the previous and current versions of the function.
| getElements().join().replace(/[\w\-:]+/g, function(nodeName) { | ||
| data.createElem(nodeName); | ||
| data.frag.createElement(nodeName); | ||
| return c("' + nodeName + '"); |
There was a problem hiding this comment.
This calls c() with the literal argument ' + nodeName + ' instead of the contents of the nodeName variable.
| getElements().join().replace(/[\w\-:]+/g, function(nodeName) { | ||
| data.createElem(nodeName); | ||
| data.frag.createElement(nodeName); | ||
| return c("' + nodeName + '"); |
There was a problem hiding this comment.
This calls c() with the literal argument ' + nodeName + ' instead of the contents of the nodeName variable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For more info look at the issue 202.