Skip to content

Commit 643aa8a

Browse files
committed
v1.0.0-beta.3
1 parent aafaae2 commit 643aa8a

10 files changed

Lines changed: 281 additions & 18 deletions

File tree

android/build.gradle

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,19 +5,19 @@ buildscript {
55
}
66

77
dependencies {
8-
classpath 'com.android.tools.build:gradle:2.2.3'
8+
classpath 'com.android.tools.build:gradle:2.3.3'
99
}
1010
}
1111

1212
apply plugin: 'com.android.library'
1313

1414
android {
15-
compileSdkVersion 25
16-
buildToolsVersion "25.0.3"
15+
compileSdkVersion 26
16+
buildToolsVersion "27.0.3"
1717

1818
defaultConfig {
1919
minSdkVersion 16
20-
targetSdkVersion 25
20+
targetSdkVersion 26
2121
versionCode 1
2222
versionName "1.0"
2323
}
52.4 KB
Binary file not shown.
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
#Wed Mar 28 10:38:41 CST 2018
2+
distributionBase=GRADLE_USER_HOME
3+
distributionPath=wrapper/dists
4+
zipStoreBase=GRADLE_USER_HOME
5+
zipStorePath=wrapper/dists
6+
distributionUrl=https\://services.gradle.org/distributions/gradle-3.3-all.zip

android/gradlew

Lines changed: 160 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

android/gradlew.bat

Lines changed: 90 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

android/src/main/java/io/amarcruz/rnmeasuretext/RNMeasureTextModule.java

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,11 @@
2222

2323
public class RNMeasureTextModule extends ReactContextBaseJavaModule {
2424

25-
public static void setAssetManager(AssetManager assetManager) {
25+
static void setAssetManager(AssetManager assetManager) {
2626
sAssetManager = assetManager;
2727
}
2828

29-
public RNMeasureTextModule(ReactApplicationContext reactContext) {
29+
RNMeasureTextModule(ReactApplicationContext reactContext) {
3030
super(reactContext);
3131
setAssetManager(reactContext.getAssets());
3232
}
@@ -50,7 +50,7 @@ public void measure(ReadableMap options, Promise promise) {
5050
TextPaint textPaint = sTextPaintInstance;
5151
@Nullable Layout layout = null;
5252

53-
final boolean allowFontScaling = true;
53+
//final boolean allowFontScaling = true;
5454
final int style = 0;
5555

5656
// width (optional)
@@ -72,7 +72,7 @@ public void measure(ReadableMap options, Promise promise) {
7272
if (options.hasKey("fontFamily")) {
7373
fontFamily = options.getString("fontFamily");
7474
}
75-
if (fontFamily != null && fontFamily != "") {
75+
if (fontFamily != null && !fontFamily.isEmpty()) {
7676
Typeface typeface = getTypeface(fontFamily, style);
7777
textPaint.setTypeface(typeface);
7878
} else {
@@ -88,8 +88,6 @@ public void measure(ReadableMap options, Promise promise) {
8888
final boolean unconstrainedWidth = width <= 0;
8989
final float spacingMultiplier = 1;
9090
final float spacingAddition = 0;
91-
final int textBreakStrategy =
92-
(Build.VERSION.SDK_INT < Build.VERSION_CODES.M) ? 0 : Layout.BREAK_STRATEGY_HIGH_QUALITY;
9391

9492
int hintWidth = 0;
9593

@@ -134,13 +132,16 @@ public void measure(ReadableMap options, Promise promise) {
134132
includeFontPadding
135133
);
136134
} else {
137-
layout = StaticLayout.Builder.obtain(text, 0, text.length(), textPaint, hintWidth)
135+
StaticLayout.Builder builder = StaticLayout.Builder.obtain(text, 0, text.length(), textPaint, hintWidth)
138136
.setAlignment(Layout.Alignment.ALIGN_NORMAL)
139137
.setLineSpacing(spacingAddition, spacingMultiplier)
140138
.setIncludePad(includeFontPadding)
141-
.setBreakStrategy(textBreakStrategy)
142-
.setHyphenationFrequency(Layout.HYPHENATION_FREQUENCY_NORMAL)
143-
.build();
139+
.setHyphenationFrequency(Layout.HYPHENATION_FREQUENCY_NORMAL);
140+
141+
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.M) {
142+
builder.setBreakStrategy(Layout.BREAK_STRATEGY_HIGH_QUALITY);
143+
}
144+
layout = builder.build();
144145
}
145146
}
146147

android/src/main/java/io/amarcruz/rnmeasuretext/RNMeasureTextPackage.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,10 @@ public List<NativeModule> createNativeModules(ReactApplicationContext reactConte
1919
return modules;
2020
}
2121

22+
public List<Class<? extends JavaScriptModule>> createJSModules() {
23+
return null;
24+
}
25+
2226
@Override
2327
public List<ViewManager> createViewManagers(ReactApplicationContext reactContext) {
2428
return Collections.emptyList();

index.d.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,10 @@ declare module "react-native-text-size" {
1313
height: number,
1414
lineCount: number,
1515
lastLineWidth: number,
16-
}
16+
};
1717

1818
interface TextSizeStatic {
19-
measure: (params: TextSizeParams) => Promise<TextSizeResult>;
19+
measure(params: TextSizeParams): Promise<TextSizeResult>;
2020
}
2121

2222
const TextSize: TextSizeStatic;

index.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@ import { Dimensions, NativeModules } from 'react-native';
22

33
const RNMeasureText = NativeModules.RNMeasureText;
44

5+
const windowDims = Dimensions.get('window')
6+
57
/**
68
* Get width, height, lineCount, and lastLineWidth values for text.
79
*
@@ -15,7 +17,7 @@ function measure (params) {
1517
return Promise.reject(new Error('missing required \'fontSize\' property'));
1618
}
1719

18-
const fontScale = Dimensions.get('window').fontScale || 1;
20+
const fontScale = windowDims.fontScale || 1;
1921

2022
if (fontScale !== 1) {
2123
params = Object.assign(

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "react-native-text-size",
3-
"version": "1.0.0-beta.2",
3+
"version": "1.0.0-beta.3",
44
"description": "Measure text height and width without laying it out.",
55
"main": "index.js",
66
"types": "./index.d.ts",

0 commit comments

Comments
 (0)