ENH: mission architecture#10
Open
aZira371 wants to merge 37 commits into
Open
Conversation
…Branch) Agent-Logs-Url: https://github.com/aZira371/RocketPy/sessions/7aeaec51-7514-4046-a8b0-037324036f38 Co-authored-by: aZira371 <99824864+aZira371@users.noreply.github.com>
…omments Agent-Logs-Url: https://github.com/aZira371/RocketPy/sessions/7aeaec51-7514-4046-a8b0-037324036f38 Co-authored-by: aZira371 <99824864+aZira371@users.noreply.github.com>
Agent-Logs-Url: https://github.com/aZira371/RocketPy/sessions/cd5d9e07-75af-4cce-8422-078f9628a69a Co-authored-by: aZira371 <99824864+aZira371@users.noreply.github.com>
Agent-Logs-Url: https://github.com/aZira371/RocketPy/sessions/cd5d9e07-75af-4cce-8422-078f9628a69a Co-authored-by: aZira371 <99824864+aZira371@users.noreply.github.com>
Agent-Logs-Url: https://github.com/aZira371/RocketPy/sessions/63cc6f82-b399-459b-8a12-a935a8580aec Co-authored-by: aZira371 <99824864+aZira371@users.noreply.github.com>
Agent-Logs-Url: https://github.com/aZira371/RocketPy/sessions/1fde99ff-a638-4ca8-bd18-40587d2c0252 Co-authored-by: aZira371 <99824864+aZira371@users.noreply.github.com>
Agent-Logs-Url: https://github.com/aZira371/RocketPy/sessions/c0445262-bfd1-4f4f-9123-52023054ee8f Co-authored-by: aZira371 <99824864+aZira371@users.noreply.github.com>
Agent-Logs-Url: https://github.com/aZira371/RocketPy/sessions/c0445262-bfd1-4f4f-9123-52023054ee8f Co-authored-by: aZira371 <99824864+aZira371@users.noreply.github.com>
Agent-Logs-Url: https://github.com/aZira371/RocketPy/sessions/c0445262-bfd1-4f4f-9123-52023054ee8f Co-authored-by: aZira371 <99824864+aZira371@users.noreply.github.com>
Agent-Logs-Url: https://github.com/aZira371/RocketPy/sessions/59acc550-0660-4213-8a0b-be68dc72eb60 Co-authored-by: aZira371 <99824864+aZira371@users.noreply.github.com>
Agent-Logs-Url: https://github.com/aZira371/RocketPy/sessions/a71d1b7b-84f0-4739-9883-8f7824595d57 Co-authored-by: aZira371 <99824864+aZira371@users.noreply.github.com>
Agent-Logs-Url: https://github.com/aZira371/RocketPy/sessions/7d040ddd-7cc4-4d93-b829-882f8dee9c27 Co-authored-by: aZira371 <99824864+aZira371@users.noreply.github.com>
Agent-Logs-Url: https://github.com/aZira371/RocketPy/sessions/7d040ddd-7cc4-4d93-b829-882f8dee9c27 Co-authored-by: aZira371 <99824864+aZira371@users.noreply.github.com>
Agent-Logs-Url: https://github.com/aZira371/RocketPy/sessions/7d040ddd-7cc4-4d93-b829-882f8dee9c27 Co-authored-by: aZira371 <99824864+aZira371@users.noreply.github.com>
Agent-Logs-Url: https://github.com/aZira371/RocketPy/sessions/7d040ddd-7cc4-4d93-b829-882f8dee9c27 Co-authored-by: aZira371 <99824864+aZira371@users.noreply.github.com>
Agent-Logs-Url: https://github.com/aZira371/RocketPy/sessions/7d040ddd-7cc4-4d93-b829-882f8dee9c27 Co-authored-by: aZira371 <99824864+aZira371@users.noreply.github.com>
Agent-Logs-Url: https://github.com/aZira371/RocketPy/sessions/056f0113-d627-4259-bf22-83bd9ea0bd3a Co-authored-by: aZira371 <99824864+aZira371@users.noreply.github.com>
Agent-Logs-Url: https://github.com/aZira371/RocketPy/sessions/056f0113-d627-4259-bf22-83bd9ea0bd3a Co-authored-by: aZira371 <99824864+aZira371@users.noreply.github.com>
Agent-Logs-Url: https://github.com/aZira371/RocketPy/sessions/056f0113-d627-4259-bf22-83bd9ea0bd3a Co-authored-by: aZira371 <99824864+aZira371@users.noreply.github.com>
Agent-Logs-Url: https://github.com/aZira371/RocketPy/sessions/056f0113-d627-4259-bf22-83bd9ea0bd3a Co-authored-by: aZira371 <99824864+aZira371@users.noreply.github.com>
Agent-Logs-Url: https://github.com/aZira371/RocketPy/sessions/83409187-5380-4ad6-a4b2-e70214d03cf2 Co-authored-by: aZira371 <99824864+aZira371@users.noreply.github.com>
Agent-Logs-Url: https://github.com/aZira371/RocketPy/sessions/fbe5846f-e62e-4267-8d52-191ce170c08b Co-authored-by: aZira371 <99824864+aZira371@users.noreply.github.com>
Agent-Logs-Url: https://github.com/aZira371/RocketPy/sessions/fbe5846f-e62e-4267-8d52-191ce170c08b Co-authored-by: aZira371 <99824864+aZira371@users.noreply.github.com>
Agent-Logs-Url: https://github.com/aZira371/RocketPy/sessions/fbe5846f-e62e-4267-8d52-191ce170c08b Co-authored-by: aZira371 <99824864+aZira371@users.noreply.github.com>
Agent-Logs-Url: https://github.com/aZira371/RocketPy/sessions/dd7a22c8-7e00-4af1-8f3f-0320d902b368 Co-authored-by: aZira371 <99824864+aZira371@users.noreply.github.com>
Agent-Logs-Url: https://github.com/aZira371/RocketPy/sessions/dd7a22c8-7e00-4af1-8f3f-0320d902b368 Co-authored-by: aZira371 <99824864+aZira371@users.noreply.github.com>
Agent-Logs-Url: https://github.com/aZira371/RocketPy/sessions/dd7a22c8-7e00-4af1-8f3f-0320d902b368 Co-authored-by: aZira371 <99824864+aZira371@users.noreply.github.com>
Agent-Logs-Url: https://github.com/aZira371/RocketPy/sessions/dd7a22c8-7e00-4af1-8f3f-0320d902b368 Co-authored-by: aZira371 <99824864+aZira371@users.noreply.github.com>
Agent-Logs-Url: https://github.com/aZira371/RocketPy/sessions/99fa3918-d664-41c6-9159-dccdd83b25cd Co-authored-by: aZira371 <99824864+aZira371@users.noreply.github.com>
Agent-Logs-Url: https://github.com/aZira371/RocketPy/sessions/99fa3918-d664-41c6-9159-dccdd83b25cd Co-authored-by: aZira371 <99824864+aZira371@users.noreply.github.com>
Agent-Logs-Url: https://github.com/aZira371/RocketPy/sessions/99fa3918-d664-41c6-9159-dccdd83b25cd Co-authored-by: aZira371 <99824864+aZira371@users.noreply.github.com>
Agent-Logs-Url: https://github.com/aZira371/RocketPy/sessions/99fa3918-d664-41c6-9159-dccdd83b25cd Co-authored-by: aZira371 <99824864+aZira371@users.noreply.github.com>
modified: rocketpy/__init__.py modified: rocketpy/body/__init__.py new file: rocketpy/body/body_resolver.py modified: rocketpy/mission/__init__.py new file: rocketpy/mission/branch_result.py new file: rocketpy/mission/flight_config.py modified: rocketpy/mission/mission.py modified: rocketpy/mission/mission_executor.py new file: rocketpy/mission/mission_result.py new file: test_nb.py new file: test_nb2.py new file: test_nb_all.py new file: test_nb_seb.py new file: tests/unit/body/test_body_resolver.py new file: tests/unit/mission/test_flight_config.py modified: tests/unit/mission/test_mission.py new file: tests/unit/mission/test_mission_result.py
…ketpy-mission-architecture # Conflicts: # rocketpy/__init__.py
…files Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
These debug/experiment scripts (test_nb*.py) were unrelated to the mission architecture work and were failing the ruff format CI check since they live outside rocketpy/, tests/, and docs/. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
- rocketpy/body/body_like.py: drop redundant `...` after Protocol method docstrings (unnecessary-ellipsis). - rocketpy/mission/mission.py, rocketpy/rocket/rocket.py: promote Stage/Deployable/RocketAdapter imports to module level now that they're verified safe (no circular import), removing import-outside-toplevel. - rocketpy/mission/mission_result.py: same for CompareFlights; rocketpy.plots is already a top-level dependency of rocketpy, so the local-import workaround was unfounded. - rocketpy/mission/mission_executor.py: drop unused FlightCompatibleRocket import (now only used inside BodyResolver). - rocketpy/mission/flight_config.py: silence unused-argument on for_branch()'s `name`, which is intentionally unused today (reserved for future error-context messages). - Test files: dict() -> literal, unused **kwargs/`t` params prefixed with underscore, unused IgnitionEvent import removed, and a targeted abstract-class-instantiated disable for the two tests that intentionally assert SeparationModel()/ParentUpdate() raise TypeError. - Updated test_mission_result.py's plot_all() monkeypatch target to rocketpy.mission.mission_result.CompareFlights, since it's now imported at module level instead of resolved dynamically at call time. pylint rocketpy/ tests/ docs/ now reports 10.00/10 (fail-under=10 in .pylintrc), matching what CI runs. Full unit suite still at 1780 passing. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Checklist
black rocketpy/ tests/) has passed locallypytest tests -m slow --runslow) have passed locallyCHANGELOG.mdhas been updated (if relevant)Current behavior
No multistage/deployable support
New behavior
Multistage and deployable through mission class implementation
Breaking change
Additional information
Enter text here...