Skip to content

Commit 4860527

Browse files
Merge pull request #43 from aa-replicated/demo/tier4
fix: chart and CI correctness fixes
2 parents 0d9b82d + aaca543 commit 4860527

6 files changed

Lines changed: 16 additions & 8 deletions

File tree

.github/workflows/pr.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,9 @@ jobs:
4343
context: .
4444
push: true
4545
platforms: linux/amd64
46-
tags: ghcr.io/aa-replicated/gameshelf:pr-${{ github.event.pull_request.number }}
46+
tags: |
47+
ghcr.io/aa-replicated/gameshelf:pr-${{ github.event.pull_request.number }}
48+
ghcr.io/aa-replicated/gameshelf:pr-${{ github.event.pull_request.number }}-${{ github.run_number }}
4749
4850
- name: Package Helm chart
4951
run: |

.github/workflows/release.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,15 +60,15 @@ jobs:
6060
6161
- name: Create Replicated release
6262
id: create-release
63-
uses: replicatedhq/replicated-actions/create-release@v1.20.0
63+
uses: replicatedhq/replicated-actions/create-release@v1
6464
with:
6565
app-slug: gameshelf
6666
api-token: ${{ secrets.REPLICATED_API_TOKEN }}
6767
yaml-dir: release/
6868
version: ${{ env.VERSION }}
6969

7070
- name: Promote to Unstable
71-
uses: replicatedhq/replicated-actions/promote-release@v1.20.0
71+
uses: replicatedhq/replicated-actions/promote-release@v1
7272
with:
7373
app-slug: gameshelf
7474
api-token: ${{ secrets.REPLICATED_API_TOKEN }}

chart/gameshelf/templates/preflight.yaml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,13 +25,14 @@ stringData:
2525
exclude: {{ .Values.postgresql.enabled }}
2626
- http:
2727
collectorName: replicated-app-reachability
28+
exclude: {{ .Values.preflight.excludeReachability }}
2829
get:
2930
url: {{ .Values.preflight.requiredEndpoint }}
3031
timeout: 10s
3132
analyzers:
3233
- textAnalyze:
3334
checkName: External Database Connectivity
34-
fileName: db-connection-check/check.log
35+
fileName: db-connection-check.log
3536
regex: "CONNECTION_OK"
3637
exclude: {{ .Values.postgresql.enabled }}
3738
outcomes:
@@ -44,6 +45,7 @@ stringData:
4445
- http:
4546
checkName: Replicated App Reachability
4647
collectorName: replicated-app-reachability
48+
exclude: {{ .Values.preflight.excludeReachability }}
4749
outcomes:
4850
- pass:
4951
when: "statusCode == 200"

chart/gameshelf/templates/support-bundle.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ stringData:
4444
- logs:
4545
collectorName: replicated-sdk
4646
selector:
47-
- app=replicated
47+
- app.kubernetes.io/name=replicated
4848
namespace: {{ .Release.Namespace }}
4949
limits:
5050
maxLines: 5000
@@ -68,7 +68,7 @@ stringData:
6868
message: "GameShelf health endpoint is not responding or returning an unhealthy status. Check the gameshelf-app logs for startup errors or crashes."
6969
- textAnalyze:
7070
checkName: Database Connection Errors
71-
fileName: gameshelf-app/*.log
71+
fileName: "*/gameshelf.log"
7272
regex: "connection refused|no such host|dial tcp.*connect: connection refused"
7373
outcomes:
7474
- fail:

chart/gameshelf/values.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -121,6 +121,7 @@ preflight:
121121
minCPU: 2
122122
minMemory: 4Gi
123123
requiredEndpoint: "https://replicated.app"
124+
excludeReachability: false
124125

125126
replicated:
126127
enabled: true

helmchart.yaml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,9 @@ spec:
77
name: gameshelf
88
chartVersion: "0.0.0"
99
values:
10-
replicated:
11-
integrationLicenseID: repl{{ LicenseFieldValue `licenseID` }}
1210
adminSecret: repl{{ ConfigOption `admin_secret`}}
11+
preflight:
12+
excludeReachability: repl{{ and IsEmbeddedCluster (not IsOnline) }}
1313
siteName: repl{{ ConfigOption `site_name`}}
1414
siteColor: repl{{ ConfigOption `site_color`}}
1515
customBrandingEnabled: repl{{ LicenseFieldValue `custom_branding_enabled` }}
@@ -20,6 +20,9 @@ spec:
2020
postgresql:
2121
image:
2222
registry: ""
23+
volumePermissions:
24+
image:
25+
registry: ""
2326
redis:
2427
image:
2528
registry: ""

0 commit comments

Comments
 (0)