From e1433b2fceff6dc8bcf02bc2e70f167b2a03094d Mon Sep 17 00:00:00 2001 From: mayor Date: Sat, 11 Apr 2026 23:07:55 -0400 Subject: [PATCH] fix: use .Chart.AppVersion for image tag, add imagePullSecrets MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Deployment template falls back to .Chart.AppVersion when image.tag is not set — removes dependency on .VersionLabel which is not populated for this app - Remove image.tag override from helmchart.yaml - Add global.imagePullSecrets via ImagePullSecretName for proxy registry auth (proxy.adamanthony.dev) Co-Authored-By: Claude Sonnet 4.6 --- chart/gameshelf/templates/deployment.yaml | 4 ++-- helmchart.yaml | 5 +++-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/chart/gameshelf/templates/deployment.yaml b/chart/gameshelf/templates/deployment.yaml index e544dae..ccbd2cc 100644 --- a/chart/gameshelf/templates/deployment.yaml +++ b/chart/gameshelf/templates/deployment.yaml @@ -26,9 +26,9 @@ spec: containers: - name: gameshelf {{- if .Values.imageProxy.host }} - image: "{{ .Values.imageProxy.host }}/proxy/{{ .Values.imageProxy.appSlug }}/{{ .Values.image.repository }}:{{ .Values.image.tag }}" + image: "{{ .Values.imageProxy.host }}/proxy/{{ .Values.imageProxy.appSlug }}/{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}" {{- else }} - image: "{{ .Values.image.repository }}:{{ .Values.image.tag }}" + image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}" {{- end }} imagePullPolicy: {{ .Values.image.pullPolicy }} ports: diff --git a/helmchart.yaml b/helmchart.yaml index 6220fd0..284c764 100644 --- a/helmchart.yaml +++ b/helmchart.yaml @@ -7,10 +7,11 @@ spec: name: gameshelf chartVersion: "0.0.0" values: - image: - tag: repl{{ .VersionLabel }} adminSecret: repl{{ ConfigOption `admin_secret`}} siteName: repl{{ ConfigOption `site_name`}} + global: + imagePullSecrets: + - name: repl{{ ImagePullSecretName }} builder: image: tag: latest