Merged
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…emove ReplicatedImageRepository for EC3 v3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
imageProxy.hostconditional fromdeployment.yaml— template now always usesimage.registry/image.repository:tagdirectlyvalues.yamlimage defaults to full proxy URL format (proxy.replicated.com+proxy/gameshelf/ghcr.io/aa-replicated/gameshelf) so CMX installs work without extra--setflagshelmchart.yamlfor EC3 v3: clearimageProxy.host, pass full image refs toReplicatedImageRegistry(so it returns the correct full proxy prefix, not just the proxy host), and remove allReplicatedImageRepositoryoverrides (undocumented function)Root cause of original bug:
ReplicatedImageRegistry "ghcr.io"(just a registry host) returnedproxy.replicated.com. The deployment template then embedded this inproxy.replicated.com/proxy/gameshelf/<value>/..., doubling the proxy host. The fix passes full image refs so the function has context to return the full prefix.Test plan
Runningkubectl describe podshould showproxy.replicated.com/proxy/gameshelf/..., notproxy.replicated.com/proxy/gameshelf/proxy.replicated.com/...)helm templateoutput shows correct proxy URLs with default values🤖 Generated with Claude Code