Skip to content

Commit 29cb917

Browse files
Guard release workflow jobs from upstream failures (pingdotgg#2146)
1 parent 9c64f12 commit 29cb917

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

.github/workflows/release.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,6 +171,7 @@ jobs:
171171
build:
172172
name: Build ${{ matrix.label }}
173173
needs: preflight
174+
if: ${{ !failure() && !cancelled() }}
174175
runs-on: ${{ matrix.runner }}
175176
timeout-minutes: 30
176177
strategy:
@@ -353,6 +354,7 @@ jobs:
353354
publish_cli:
354355
name: Publish CLI to npm
355356
needs: [preflight, build]
357+
if: ${{ !failure() && !cancelled() }}
356358
runs-on: ubuntu-24.04 # blacksmith-8vcpu-ubuntu-2404
357359
timeout-minutes: 10
358360
steps:
@@ -387,6 +389,7 @@ jobs:
387389
release:
388390
name: Publish GitHub Release
389391
needs: [preflight, build, publish_cli]
392+
if: ${{ !failure() && !cancelled() }}
390393
runs-on: ubuntu-24.04 # blacksmith-8vcpu-ubuntu-2404
391394
timeout-minutes: 10
392395
steps:
@@ -496,7 +499,7 @@ jobs:
496499

497500
finalize:
498501
name: Finalize release
499-
if: needs.preflight.outputs.release_channel == 'stable'
502+
if: ${{ !failure() && !cancelled() && needs.preflight.outputs.release_channel == 'stable' }}
500503
needs: [preflight, release]
501504
runs-on: blacksmith-8vcpu-ubuntu-2404
502505
timeout-minutes: 10

0 commit comments

Comments
 (0)