fix: address critical review findings on upstream sync

1. apps/desktop/src/main.ts: remove duplicate
   GET_LOCAL_ENVIRONMENT_BOOTSTRAP_CHANNEL handler that shadowed the
   correct upstream handler with the fork's legacy { label, wsUrl }
   shape. The contract-compliant handler at line 1551-1563 now wins.

2. apps/desktop/src/main.ts: wire updateInstallInFlight into
   installDownloadedUpdate (set true on install start, cleared on
   error) and resolveUpdaterErrorContext so channel-switch guards
   and error-context reporting see the install-in-flight state.

3. apps/server/src/provider/providerStatusCache.ts: revert
   PROVIDER_CACHE_IDS to [codex, claudeAgent] (the set the registry
   actually caches). Fix ProviderRegistry.persistProvider to skip
   non-cached provider kinds without a non-null-assertion crash.

Author: aaditagrawal

apps/desktop/src/main.ts

@@ -642,6 +642,7 @@ let updaterConfigured = false;
 let updateState: DesktopUpdateState = initialUpdateState();
 
 function resolveUpdaterErrorContext(): DesktopUpdateErrorContext {
+  if (updateInstallInFlight) return "install";
   if (updateDownloadInFlight) return "download";
   if (updateCheckInFlight) return "check";
   return updateState.errorContext;
@@ -1219,13 +1220,15 @@ async function installDownloadedUpdate(): Promise<{ accepted: boolean; completed
   }
 
   isQuitting = true;
+  updateInstallInFlight = true;
   clearUpdatePollTimer();
   try {
     await stopBackendAndWaitForExit();
     autoUpdater.quitAndInstall();
     return { accepted: true, completed: true };
   } catch (error: unknown) {
     const message = formatErrorMessage(error);
+    updateInstallInFlight = false;
     isQuitting = false;
     setUpdateState(reduceDesktopUpdateStateOnInstallFailure(updateState, message));
     console.error(`[desktop-updater] Failed to install update: ${message}`);
@@ -1664,14 +1667,6 @@ function registerIpcHandlers(): void {
     return nextState;
   });
 
-  ipcMain.removeAllListeners(GET_LOCAL_ENVIRONMENT_BOOTSTRAP_CHANNEL);
-  ipcMain.on(GET_LOCAL_ENVIRONMENT_BOOTSTRAP_CHANNEL, (event) => {
-    event.returnValue = {
-      label: "Local environment",
-      wsUrl: backendWsUrl || null,
-    } as const;
-  });
-
   ipcMain.removeHandler(PICK_FOLDER_CHANNEL);
   ipcMain.handle(PICK_FOLDER_CHANNEL, async (_event, rawOptions: unknown) => {
     const owner = BrowserWindow.getFocusedWindow() ?? mainWindow;

apps/server/src/provider/Layers/ProviderRegistry.ts

@@ -91,16 +91,21 @@ export const ProviderRegistryLive = Layer.effect(
     );
     const providersRef = yield* Ref.make<ReadonlyArray<ServerProvider>>(cachedProviders);
 
-    const persistProvider = (provider: ServerProvider) =>
-      writeProviderStatusCache({
-        filePath: cachePathByProvider.get(provider.provider)!,
+    const persistProvider = (provider: ServerProvider) => {
+      const filePath = cachePathByProvider.get(
+        provider.provider as (typeof PROVIDER_CACHE_IDS)[number],
+      );
+      if (!filePath) return Effect.void;
+      return writeProviderStatusCache({
+        filePath,
         provider,
       }).pipe(
         Effect.provideService(FileSystem.FileSystem, fileSystem),
         Effect.provideService(Path.Path, path),
         Effect.tapError(Effect.logError),
         Effect.ignore,
       );
+    };
 
     const upsertProviders = Effect.fn("upsertProviders")(function* (
       nextProviders: ReadonlyArray<ServerProvider>,

apps/server/src/provider/providerStatusCache.ts

@@ -2,23 +2,16 @@ import * as nodePath from "node:path";
 import { type ServerProvider, ServerProvider as ServerProviderSchema } from "@t3tools/contracts";
 import { Cause, Effect, FileSystem, Path, Schema } from "effect";
 
-export const PROVIDER_CACHE_IDS = [
-  "codex",
-  "claudeAgent",
-  "copilot",
-  "cursor",
-  "opencode",
-  "geminiCli",
-  "amp",
-  "kilo",
-] as const satisfies ReadonlyArray<ServerProvider["provider"]>;
+export const PROVIDER_CACHE_IDS = ["codex", "claudeAgent"] as const satisfies ReadonlyArray<
+  ServerProvider["provider"]
+>;
 
 const decodeProviderStatusCache = Schema.decodeUnknownEffect(
   Schema.fromJsonString(ServerProviderSchema),
 );
 
 const providerOrderRank = (provider: ServerProvider["provider"]): number => {
-  const rank = PROVIDER_CACHE_IDS.indexOf(provider);
+  const rank = (PROVIDER_CACHE_IDS as ReadonlyArray<ServerProvider["provider"]>).indexOf(provider);
   return rank === -1 ? Number.MAX_SAFE_INTEGER : rank;
 };