Skip to content

Commit 8ac57f7

Browse files
Guard release workflow jobs on upstream success (pingdotgg#2147)
1 parent 29cb917 commit 8ac57f7

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

.github/workflows/release.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ jobs:
171171
build:
172172
name: Build ${{ matrix.label }}
173173
needs: preflight
174-
if: ${{ !failure() && !cancelled() }}
174+
if: ${{ !failure() && !cancelled() && needs.preflight.result == 'success' }}
175175
runs-on: ${{ matrix.runner }}
176176
timeout-minutes: 30
177177
strategy:
@@ -354,7 +354,7 @@ jobs:
354354
publish_cli:
355355
name: Publish CLI to npm
356356
needs: [preflight, build]
357-
if: ${{ !failure() && !cancelled() }}
357+
if: ${{ !failure() && !cancelled() && needs.preflight.result == 'success' && needs.build.result == 'success' }}
358358
runs-on: ubuntu-24.04 # blacksmith-8vcpu-ubuntu-2404
359359
timeout-minutes: 10
360360
steps:
@@ -389,7 +389,7 @@ jobs:
389389
release:
390390
name: Publish GitHub Release
391391
needs: [preflight, build, publish_cli]
392-
if: ${{ !failure() && !cancelled() }}
392+
if: ${{ !failure() && !cancelled() && needs.preflight.result == 'success' && needs.build.result == 'success' && needs.publish_cli.result == 'success' }}
393393
runs-on: ubuntu-24.04 # blacksmith-8vcpu-ubuntu-2404
394394
timeout-minutes: 10
395395
steps:
@@ -499,7 +499,7 @@ jobs:
499499

500500
finalize:
501501
name: Finalize release
502-
if: ${{ !failure() && !cancelled() && needs.preflight.outputs.release_channel == 'stable' }}
502+
if: ${{ !failure() && !cancelled() && needs.preflight.result == 'success' && needs.release.result == 'success' && needs.preflight.outputs.release_channel == 'stable' }}
503503
needs: [preflight, release]
504504
runs-on: blacksmith-8vcpu-ubuntu-2404
505505
timeout-minutes: 10

0 commit comments

Comments
 (0)