Skip to content

fix: sans-serif inputs + Cmd+K capture phase #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aaditagrawal merged 2 commits into from
Apr 19, 2026
Merged

fix: sans-serif inputs + Cmd+K capture phase #72

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc814b2
fix: restore sans-serif for inputs; make Cmd+K work in capture phase
aaditagrawal Apr 19, 2026
fa82fbc
fix: apply font-mono to code-content textareas
aaditagrawal Apr 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions apps/web/src/components/CommandPalette.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,8 +171,10 @@ export function CommandPalette({ children }: { children: ReactNode }) {
event.stopPropagation();
toggleOpen();
};
window.addEventListener("keydown", onKeyDown);
return () => window.removeEventListener("keydown", onKeyDown);
// Capture phase so the shortcut fires even when a descendant (e.g.
// xterm, a contenteditable composer) would otherwise swallow the event.
window.addEventListener("keydown", onKeyDown, true);
return () => window.removeEventListener("keydown", onKeyDown, true);
}, [keybindings, terminalOpen, toggleOpen]);

return (
Expand Down
4 changes: 1 addition & 3 deletions apps/web/src/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,9 +177,7 @@ body::after {
}

pre,
code,
textarea,
input {
code {
font-family:
"Geist Mono", "SF Mono", "SFMono-Regular", Consolas, "Liberation Mono", Menlo, monospace;
}
Comment on lines 179 to 183
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Apr 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Find textareas in the web app and check whether they apply a monospace font class/style.
fd -e tsx -e ts . apps/web/src --exec rg -nP -C2 '<textarea\b|Textarea\b' {} \;
# Highlight any that reference font-mono / Geist Mono / var(--font-mono)
rg -nP --type=ts --type=tsx 'font-mono|Geist Mono|var\(--font-mono\)' apps/web/src

Repository: aaditagrawal/t3code

Length of output: 2650

🏁 Script executed:

# First, find and read the Textarea component definition
find apps/web/src -name "textarea*" -type f | head -10

Repository: aaditagrawal/t3code

Length of output: 102

🏁 Script executed:

# Search with correct file type handling (no tsx file type needed for rg)
rg 'font-mono|Geist Mono|font-family.*monospace' apps/web/src --type=ts -A 2 -B 2

Repository: aaditagrawal/t3code

Length of output: 8033

🏁 Script executed:

# Look for Textarea component definition
rg -A 15 'function Textarea\(' apps/web/src

Repository: aaditagrawal/t3code

Length of output: 1942

🏁 Script executed:

# Search in CSS/style files for monospace font definitions related to textareas or inputs
find apps/web/src -name "*.css" -o -name "*.scss" | xargs grep -l 'textarea\|input' 2>/dev/null

Repository: aaditagrawal/t3code

Length of output: 85

🏁 Script executed:

# Read the exact CSS lines mentioned in the review
sed -n '170,190p' apps/web/src/index.css

Repository: aaditagrawal/t3code

Length of output: 748

🏁 Script executed:

# Read the full Textarea component
cat -n apps/web/src/components/ui/textarea.tsx

Repository: aaditagrawal/t3code

Length of output: 2562

🏁 Script executed:

# Check specific textarea usages: script command (project-dialog) and commit message (thread-view)
rg -B 3 -A 3 'script-command|dialogCommitMessage' apps/web/src

Repository: aaditagrawal/t3code

Length of output: 3424

🏁 Script executed:

# Check if the specific script-command and commit message textareas have any monospace styling
rg -B 5 -A 8 'id="script-command"' apps/web/src

Repository: aaditagrawal/t3code

Length of output: 1381

🏁 Script executed:

# Check the commit message textarea more thoroughly
rg -B 10 -A 10 'placeholder="Leave empty to auto-generate"' apps/web/src

Repository: aaditagrawal/t3code

Length of output: 1731

🏁 Script executed:

# Search for any className containing font-mono applied to Textarea components
rg -B 2 -A 8 '<Textarea' apps/web/src --type=ts

Repository: aaditagrawal/t3code

Length of output: 3708

Critical: Textareas lack explicit monospace styling after global rule removal.

The CSS change correctly narrows the selector to pre, code, but verification shows that code-related <textarea> elements (script commands in ProjectScriptsControl.tsx and commit messages in GitActionsControl.tsx) do not have explicit monospace font classes applied. These textareas will now render in DM Sans instead of monospace, degrading readability of code-like content.

Add className="font-mono" to:

  • <Textarea> in ProjectScriptsControl.tsx (script-command textarea)
  • <Textarea> in GitActionsControl.tsx (commit message textarea)
🧰 Tools
🪛 Stylelint (17.7.0)

[error] 182-182: Expected no quotes around "SFMono-Regular" (font-family-name-quotes)

(font-family-name-quotes)

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@apps/web/src/index.css` around lines 179 - 183, The global CSS change removed
textarea from the monospace rule so code-like textareas now render in the wrong
font; update the Textarea instances to explicitly use the monospace utility by
adding className="font-mono" to the script-command Textarea in
ProjectScriptsControl.tsx (the textarea used for the script command input) and
to the commit message Textarea in GitActionsControl.tsx (the textarea used for
commit messages) so they render in monospace regardless of global rules.

Expand Down
Loading