Add main field to package.json#73
Open
JohnstonCode wants to merge 1 commit into
Open
Conversation
The main field was missing from the package.json that was stopping me from requiring jschardet when bundled in a .asar
|
Would love to see this merged as well. VS Code has a similar problem where we hardcode the entrypoint for jschardet when loading it in the web because it doesn't specify where to load it from. |
|
Azure data studio also has this issue that throws a warning. It's a one line change, can we get it pulled in? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main field was missing from the package.json that was stopping me from requiring jschardet when bundled in a .asar