PHP 8.x support

[shawn-crigger]

Just curious but does this package support PHP 8?

❯ wp package install aaemnnosttv/wp-cli-valet-command:@stable
Installing package aaemnnosttv/wp-cli-valet-command (@stable)
Updating /Users/shawnc/.wp-cli/packages/composer.json to require the package...
Using Composer to install the package...
---
Loading composer repositories with package information
Found 2,620 package versions referenced in your dependency graph. 2,342 (89%) were optimized away.
Updating dependencies
Generating rules
Resolving dependencies through SAT
Looking at all rules.
Something's changed, looking at all rules again (pass #1)

Dependency resolution completed in 0.000 seconds
Analyzed 278 packages to resolve dependencies
Analyzed 568 rules to resolve dependencies
Lock file operations: 13 installs, 0 updates, 0 removals
Installs: wp-cli/db-command:v2.1.2, composer/semver:3.4.3, wp-cli/core-command:v2.1.18, wp-cli/wp-config-transformer:v1.4.1, wp-cli/config-command:v2.3.7, symfony/polyfill-php80:v1.31.0, symfony/polyfill-ctype:v1.31.0, symfony/filesystem:v4.4.42, psr/container:1.1.2, psr/simple-cache:1.0.1, illuminate/contracts:v8.83.27, illuminate/container:v8.83.27, aaemnnosttv/wp-cli-valet-command:v1.3.1
- Locking aaemnnosttv/wp-cli-valet-command (v1.3.1)
- Locking composer/semver (3.4.3)
- Locking illuminate/container (v8.83.27)
- Locking illuminate/contracts (v8.83.27)
- Locking psr/container (1.1.2)
- Locking psr/simple-cache (1.0.1)
- Locking symfony/filesystem (v4.4.42)
- Locking symfony/polyfill-ctype (v1.31.0)
- Locking symfony/polyfill-php80 (v1.31.0)
- Locking wp-cli/config-command (v2.3.7)
- Locking wp-cli/core-command (v2.1.18)
- Locking wp-cli/db-command (v2.1.2)
- Locking wp-cli/wp-config-transformer (v1.4.1)
Writing lock file
Installing dependencies from lock file
Package operations: 13 installs, 0 updates, 0 removals
Installs: wp-cli/db-command:v2.1.2, composer/semver:3.4.3, wp-cli/core-command:v2.1.18, wp-cli/wp-config-transformer:v1.4.1, wp-cli/config-command:v2.3.7, symfony/polyfill-php80:v1.31.0, symfony/polyfill-ctype:v1.31.0, symfony/filesystem:v4.4.42, psr/container:1.1.2, psr/simple-cache:1.0.1, illuminate/contracts:v8.83.27, illuminate/container:v8.83.27, aaemnnosttv/wp-cli-valet-command:v1.3.1

Deprecated: Return type of Symfony\Component\Process\Process::getIterator($flags = 0) should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///opt/homebrew/Cellar/wp-cli/2.11.0/bin/wp/vendor/symfony/process/Process.php on line 567
 - Installing <info>wp-cli/db-command</info> (<comment>v2.1.2</comment>)

Deprecated: Return type of Symfony\Component\Finder\Finder::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///opt/homebrew/Cellar/wp-cli/2.11.0/bin/wp/vendor/symfony/finder/Finder.php on line 566

Deprecated: Return type of Symfony\Component\Finder\Finder::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///opt/homebrew/Cellar/wp-cli/2.11.0/bin/wp/vendor/symfony/finder/Finder.php on line 637

Deprecated: Return type of Symfony\Component\Finder\Iterator\RecursiveDirectoryIterator::getChildren() should either be compatible with RecursiveDirectoryIterator::getChildren(): RecursiveDirectoryIterator, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///opt/homebrew/Cellar/wp-cli/2.11.0/bin/wp/vendor/symfony/finder/Iterator/RecursiveDirectoryIterator.php on line 89

Deprecated: Return type of Symfony\Component\Finder\Iterator\RecursiveDirectoryIterator::rewind() should either be compatible with FilesystemIterator::rewind(): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///opt/homebrew/Cellar/wp-cli/2.11.0/bin/wp/vendor/symfony/finder/Iterator/RecursiveDirectoryIterator.php on line 117

Deprecated: Return type of Symfony\Component\Finder\Iterator\RecursiveDirectoryIterator::current() should either be compatible with FilesystemIterator::current(): SplFileInfo|FilesystemIterator|string, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///opt/homebrew/Cellar/wp-cli/2.11.0/bin/wp/vendor/symfony/finder/Iterator/RecursiveDirectoryIterator.php on line 65

Deprecated: Return type of Symfony\Component\Finder\Iterator\FilterIterator::rewind() should either be compatible with FilterIterator::rewind(): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///opt/homebrew/Cellar/wp-cli/2.11.0/bin/wp/vendor/symfony/finder/Iterator/FilterIterator.php on line 32

Deprecated: Return type of Symfony\Component\Finder\Iterator\DepthRangeFilterIterator::accept() should either be compatible with FilterIterator::accept(): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///opt/homebrew/Cellar/wp-cli/2.11.0/bin/wp/vendor/symfony/finder/Iterator/DepthRangeFilterIterator.php on line 41
 - Installing <info>composer/semver</info> (<comment>3.4.3</comment>)
 - Installing <info>wp-cli/core-command</info> (<comment>v2.1.18</comment>)
 - Installing <info>wp-cli/wp-config-transformer</info> (<comment>v1.4.1</comment>)
 - Installing <info>wp-cli/config-command</info> (<comment>v2.3.7</comment>)
 - Installing <info>symfony/polyfill-php80</info> (<comment>v1.31.0</comment>)
 - Installing <info>symfony/polyfill-ctype</info> (<comment>v1.31.0</comment>)
 - Installing <info>symfony/filesystem</info> (<comment>v4.4.42</comment>)
 - Installing <info>psr/container</info> (<comment>1.1.2</comment>)
 - Installing <info>psr/simple-cache</info> (<comment>1.0.1</comment>)
 - Installing <info>illuminate/contracts</info> (<comment>v8.83.27</comment>)
 - Installing <info>illuminate/container</info> (<comment>v8.83.27</comment>)
 - Installing <info>aaemnnosttv/wp-cli-valet-command</info> (<comment>v1.3.1</comment>)
Generating autoload files

Deprecated: Return type of Symfony\Component\Finder\Iterator\FileTypeFilterIterator::accept() should either be compatible with FilterIterator::accept(): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///opt/homebrew/Cellar/wp-cli/2.11.0/bin/wp/vendor/symfony/finder/Iterator/FileTypeFilterIterator.php on line 42

Deprecated: Return type of Symfony\Component\Finder\Iterator\ExcludeDirectoryFilterIterator::accept() should either be compatible with FilterIterator::accept(): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///opt/homebrew/Cellar/wp-cli/2.11.0/bin/wp/vendor/symfony/finder/Iterator/ExcludeDirectoryFilterIterator.php on line 55

Deprecated: Return type of Symfony\Component\Finder\Iterator\ExcludeDirectoryFilterIterator::hasChildren() should either be compatible with RecursiveIterator::hasChildren(): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///opt/homebrew/Cellar/wp-cli/2.11.0/bin/wp/vendor/symfony/finder/Iterator/ExcludeDirectoryFilterIterator.php on line 71

Deprecated: Return type of Symfony\Component\Finder\Iterator\ExcludeDirectoryFilterIterator::getChildren() should either be compatible with RecursiveIterator::getChildren(): ?RecursiveIterator, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///opt/homebrew/Cellar/wp-cli/2.11.0/bin/wp/vendor/symfony/finder/Iterator/ExcludeDirectoryFilterIterator.php on line 76

Deprecated: Return type of Symfony\Component\Finder\Iterator\FilterIterator::rewind() should either be compatible with Iterator::rewind(): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///opt/homebrew/Cellar/wp-cli/2.11.0/bin/wp/vendor/symfony/finder/Iterator/FilterIterator.php on line 32

Deprecated: Return type of Symfony\Component\Finder\Iterator\FilenameFilterIterator::accept() should either be compatible with FilterIterator::accept(): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///opt/homebrew/Cellar/wp-cli/2.11.0/bin/wp/vendor/symfony/finder/Iterator/FilenameFilterIterator.php on line 28

Deprecated: Return type of Symfony\Component\Finder\Iterator\PathFilterIterator::accept() should either be compatible with FilterIterator::accept(): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///opt/homebrew/Cellar/wp-cli/2.11.0/bin/wp/vendor/symfony/finder/Iterator/PathFilterIterator.php on line 27
4 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
---
Success: Package installed.
❯ wp package install aaemnnosttv/wp-cli-valet-command:dev-master

Installing package aaemnnosttv/wp-cli-valet-command (dev-master)
Updating /Users/shawnc/.wp-cli/packages/composer.json to require the package...
Using Composer to install the package...
---
Loading composer repositories with package information
Found 1,573 package versions referenced in your dependency graph. 1,398 (89%) were optimized away.
Updating dependencies
Generating rules
Resolving dependencies through SAT
Looking at all rules.
Something's changed, looking at all rules again (pass #1)

Dependency resolution completed in 0.000 seconds
Analyzed 175 packages to resolve dependencies
Analyzed 247 rules to resolve dependencies
Lock file operations: 0 installs, 1 update, 0 removals
Updates: aaemnnosttv/wp-cli-valet-command:dev-master b30aaf3
- Upgrading aaemnnosttv/wp-cli-valet-command (v1.3.1 => dev-master b30aaf3)
Writing lock file
Installing dependencies from lock file
Package operations: 0 installs, 1 update, 0 removals
Updates: aaemnnosttv/wp-cli-valet-command:dev-master b30aaf3

Deprecated: Return type of Symfony\Component\Process\Process::getIterator($flags = 0) should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///opt/homebrew/Cellar/wp-cli/2.11.0/bin/wp/vendor/symfony/process/Process.php on line 567
Generating autoload files

Deprecated: Return type of Symfony\Component\Finder\Finder::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///opt/homebrew/Cellar/wp-cli/2.11.0/bin/wp/vendor/symfony/finder/Finder.php on line 566

Deprecated: Return type of Symfony\Component\Finder\Finder::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///opt/homebrew/Cellar/wp-cli/2.11.0/bin/wp/vendor/symfony/finder/Finder.php on line 637

Deprecated: Return type of Symfony\Component\Finder\Iterator\FilterIterator::rewind() should either be compatible with FilterIterator::rewind(): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///opt/homebrew/Cellar/wp-cli/2.11.0/bin/wp/vendor/symfony/finder/Iterator/FilterIterator.php on line 32

Deprecated: Return type of Symfony\Component\Finder\Iterator\FileTypeFilterIterator::accept() should either be compatible with FilterIterator::accept(): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///opt/homebrew/Cellar/wp-cli/2.11.0/bin/wp/vendor/symfony/finder/Iterator/FileTypeFilterIterator.php on line 42

Deprecated: Return type of Symfony\Component\Finder\Iterator\RecursiveDirectoryIterator::getChildren() should either be compatible with RecursiveDirectoryIterator::getChildren(): RecursiveDirectoryIterator, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///opt/homebrew/Cellar/wp-cli/2.11.0/bin/wp/vendor/symfony/finder/Iterator/RecursiveDirectoryIterator.php on line 89

Deprecated: Return type of Symfony\Component\Finder\Iterator\RecursiveDirectoryIterator::rewind() should either be compatible with FilesystemIterator::rewind(): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///opt/homebrew/Cellar/wp-cli/2.11.0/bin/wp/vendor/symfony/finder/Iterator/RecursiveDirectoryIterator.php on line 117

Deprecated: Return type of Symfony\Component\Finder\Iterator\RecursiveDirectoryIterator::current() should either be compatible with FilesystemIterator::current(): SplFileInfo|FilesystemIterator|string, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///opt/homebrew/Cellar/wp-cli/2.11.0/bin/wp/vendor/symfony/finder/Iterator/RecursiveDirectoryIterator.php on line 65

Deprecated: Return type of Symfony\Component\Finder\Iterator\ExcludeDirectoryFilterIterator::accept() should either be compatible with FilterIterator::accept(): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///opt/homebrew/Cellar/wp-cli/2.11.0/bin/wp/vendor/symfony/finder/Iterator/ExcludeDirectoryFilterIterator.php on line 55

Deprecated: Return type of Symfony\Component\Finder\Iterator\ExcludeDirectoryFilterIterator::hasChildren() should either be compatible with RecursiveIterator::hasChildren(): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///opt/homebrew/Cellar/wp-cli/2.11.0/bin/wp/vendor/symfony/finder/Iterator/ExcludeDirectoryFilterIterator.php on line 71

Deprecated: Return type of Symfony\Component\Finder\Iterator\ExcludeDirectoryFilterIterator::getChildren() should either be compatible with RecursiveIterator::getChildren(): ?RecursiveIterator, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///opt/homebrew/Cellar/wp-cli/2.11.0/bin/wp/vendor/symfony/finder/Iterator/ExcludeDirectoryFilterIterator.php on line 76

Deprecated: Return type of Symfony\Component\Finder\Iterator\FilterIterator::rewind() should either be compatible with Iterator::rewind(): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///opt/homebrew/Cellar/wp-cli/2.11.0/bin/wp/vendor/symfony/finder/Iterator/FilterIterator.php on line 32

Deprecated: Return type of Symfony\Component\Finder\Iterator\FilenameFilterIterator::accept() should either be compatible with FilterIterator::accept(): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///opt/homebrew/Cellar/wp-cli/2.11.0/bin/wp/vendor/symfony/finder/Iterator/FilenameFilterIterator.php on line 28

Deprecated: Return type of Symfony\Component\Finder\Iterator\PathFilterIterator::accept() should either be compatible with FilterIterator::accept(): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///opt/homebrew/Cellar/wp-cli/2.11.0/bin/wp/vendor/symfony/finder/Iterator/PathFilterIterator.php on line 27
4 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
---
Success: Package installed.

I'm using PHP 8.1.3 on Mac and both Valet and WP CLI are installed and work fine. It installed WP correctly but I was just curious if anyone is interested in fixing the deprecated warning. If I find some time when I get my current projects done I would be happy to take a look at it. It's nothing super important just annoying to me to see warnings.

[jerome-toole]

I'm not able to use wp valet new at all with PHP >8.2 as I get fatal errors.

So I'm now using it with 8.1 like this:
/opt/homebrew/opt/php@8.1/bin/php $(which wp) valet new <<site>>

My alias in .zshrc:
alias wp81='/opt/homebrew/opt/php@8.1/bin/php $(which wp)'

Usage:
wp81 valet new <<site>>

[ara303]

Adding PHP8.x support to this package appears easy because it's well made. Just needs a dependency version bump in composer.json, by the looks of things:

           "WP_CLI_Valet\\Tests\\": "tests/"
       }
   },
   "require": {
-      "php": ">=5.5",
-      "illuminate/container": ">=5.1 <5.7 || ^6.5.1 || ^7 || ^8",
-      "symfony/filesystem": "^2.7 || ^3 || ^4",
+      "php": ">=7.2",
+      "illuminate/container": ">=5.1 <5.7 || ^6.5.1 || ^7 || ^8 || ^9 || ^10 || ^11 || ^12",
+      "symfony/filesystem": "^2.7 || ^3 || ^4 || ^5 || ^6 || ^7",
       "wp-cli/config-command": "^1 || ^2",
       "wp-cli/core-command": "^1 || ^2",
       "wp-cli/db-command": "^1 || ^2",
       "wp-cli/wp-cli": "^1 || ^2"

I am happy to PR this. Would you be interested in considering a PR, @aaemnnosttv? I'll put one together if so.

---

Edit: PR made. See #96.

[aaemnnosttv]

Hey @ara303, a PR would be great, feel free to raise one 👍