Skip to content

PHP 8.5 compatibility #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aaemnnosttv wants to merge 4 commits into
base: master
Choose a base branch
from
+8 −10
Open

PHP 8.5 compatibility #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b11b781
Update test workflow
aaemnnosttv Mar 20, 2026
06352d9
Loosen dependency constraints
aaemnnosttv Mar 20, 2026
1451353
Don't fail on schema warnings
aaemnnosttv Mar 20, 2026
9e9c68d
Use getenv for environment variables in test
aaemnnosttv Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,31 +20,29 @@ jobs:
php-version: ['7.4']
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6

- name: Setup PHP
uses: shivammathur/setup-php@v2
with:
php-version: ${{ matrix.php-version }}
tools: composer

- name: Validate composer.json
run: composer validate --strict
run: composer validate

behat:
needs: lint
strategy:
matrix:
php-version: ['7.4', '8.2']
php-version: ['7.4', '8.2', '8.5']
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6

- name: Setup PHP
uses: shivammathur/setup-php@v2
with:
php-version: ${{ matrix.php-version }}
tools: composer

- run: composer install

Expand Down
4 changes: 2 additions & 2 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@
},
"require": {
"php": ">=5.5",
"illuminate/container": ">=5.1 <5.7 || ^6.5.1 || ^7 || ^8",
"symfony/filesystem": "^2.7 || ^3 || ^4",
"illuminate/container": ">=5.1 <5.7 || >=6",
"symfony/filesystem": ">=2.7",
"wp-cli/config-command": "^1 || ^2",
"wp-cli/core-command": "^1 || ^2",
"wp-cli/db-command": "^1 || ^2",
Expand Down
4 changes: 2 additions & 2 deletions features/valet-new-project-bedrock.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ Feature: It can create new installs for Valet-supported WordPress projects.
"""
DB_PREFIX='foo'
"""
And I run `wp eval 'echo $_SERVER["DB_PREFIX"];' --path={PATH}/{PROJECT}/web/wp/`
And I run `wp eval 'echo getenv("DB_PREFIX");' --path={PATH}/{PROJECT}/web/wp/`
Then STDOUT should be:
"""
foo
Expand All @@ -70,7 +70,7 @@ Feature: It can create new installs for Valet-supported WordPress projects.
"""
DB_HOST='127.0.0.1'
"""
And I run `wp eval 'echo $_SERVER["DB_HOST"];' --path={PROJECT}/web/wp/`
And I run `wp eval 'echo getenv("DB_HOST");' --path={PROJECT}/web/wp/`
Then STDOUT should be:
"""
127.0.0.1
Expand Down