Fix PHP 8.5 deprecation of PDO::sqliteCreateFunction()#70
Merged
aaemnnosttv merged 1 commit intoaaemnnosttv:masterfrom Mar 18, 2026
Merged
Conversation
0ec890b to
22c8c44
Compare
PHP 8.5 deprecated PDO::sqliteCreateFunction() in favor of Pdo\Sqlite::createFunction(). Use the new method on PHP 8.0+ where it is available, falling back to the old method for older versions. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
22c8c44 to
1dd07a5
Compare
|
Commenting here because it's relevant to my PR on This solution works, having tested with both PHP 8.5 and 8.4. If merged, this solves the one last deprecation notice I'm trying to squash on my PR. 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PDO::sqliteCreateFunction()in favor ofPdo\Sqlite::createFunction()createFunction()method on PHP 8.0+ (where it was introduced), falling back to the old method for PHP < 8.0Test plan
sqliteCreateFunction())createFunction())🤖 Generated with Claude Code