Skip to content

Commit 7886810

Browse files
aalmadaaalmada
committed
refactor: rename discard variable to scope for Assert.Multiple in tests
1 parent 5e41ebe commit 7886810

3 files changed

Lines changed: 19 additions & 19 deletions

File tree

‎src/ApiService/BookStore.ApiService.Tests/ConfigurationValidationTests.cs‎

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ public async Task PaginationOptions_DefaultPageSizeNegative_FailsValidation()
4141
var results = ValidateModel(options);
4242

4343
// Assert
44-
using var _ = Assert.Multiple();
44+
using var scope = Assert.Multiple();
4545
_ = await Assert.That(results).Count().IsEqualTo(1);
4646
_ = await Assert.That(results[0].ErrorMessage).Contains("DefaultPageSize must be between 1 and 1000");
4747
}
@@ -61,7 +61,7 @@ public async Task PaginationOptions_DefaultPageSizeZero_FailsValidation()
6161
var results = ValidateModel(options);
6262

6363
// Assert
64-
using var _ = Assert.Multiple();
64+
using var scope = Assert.Multiple();
6565
_ = await Assert.That(results).Count().IsEqualTo(1);
6666
_ = await Assert.That(results[0].ErrorMessage).Contains("DefaultPageSize must be between 1 and 1000");
6767
}
@@ -81,7 +81,7 @@ public async Task PaginationOptions_DefaultPageSizeTooLarge_FailsValidation()
8181
var results = ValidateModel(options);
8282

8383
// Assert
84-
using var _ = Assert.Multiple();
84+
using var scope = Assert.Multiple();
8585
_ = await Assert.That(results).Count().IsGreaterThanOrEqualTo(1);
8686
_ = await Assert.That(results.Any(r => r.ErrorMessage!.Contains("DefaultPageSize must be between 1 and 1000"))).IsTrue();
8787
}
@@ -101,7 +101,7 @@ public async Task PaginationOptions_MaxPageSizeNegative_FailsValidation()
101101
var results = ValidateModel(options);
102102

103103
// Assert
104-
using var _ = Assert.Multiple();
104+
using var scope = Assert.Multiple();
105105
_ = await Assert.That(results).Count().IsEqualTo(1);
106106
_ = await Assert.That(results[0].ErrorMessage).Contains("MaxPageSize must be between 1 and 1000");
107107
}
@@ -121,7 +121,7 @@ public async Task PaginationOptions_MaxPageSizeZero_FailsValidation()
121121
var results = ValidateModel(options);
122122

123123
// Assert
124-
using var _ = Assert.Multiple();
124+
using var scope = Assert.Multiple();
125125
_ = await Assert.That(results).Count().IsEqualTo(1);
126126
_ = await Assert.That(results[0].ErrorMessage).Contains("MaxPageSize must be between 1 and 1000");
127127
}
@@ -141,7 +141,7 @@ public async Task PaginationOptions_DefaultPageSizeGreaterThanMaxPageSize_FailsV
141141
var results = ValidateModel(options);
142142

143143
// Assert
144-
using var _ = Assert.Multiple();
144+
using var scope = Assert.Multiple();
145145
_ = await Assert.That(results).Count().IsEqualTo(1);
146146
_ = await Assert.That(results[0].ErrorMessage).Contains("DefaultPageSize (100) cannot be greater than MaxPageSize (50)");
147147
}
@@ -179,7 +179,7 @@ public async Task LocalizationOptions_DefaultCultureEmpty_FailsValidation()
179179
var results = ValidateModel(options);
180180

181181
// Assert
182-
using var _ = Assert.Multiple();
182+
using var scope = Assert.Multiple();
183183
_ = await Assert.That(results).IsNotEmpty();
184184
_ = await Assert.That(results.Any(r => r.ErrorMessage!.Contains("DefaultCulture"))).IsTrue();
185185
}
@@ -199,7 +199,7 @@ public async Task LocalizationOptions_SupportedCulturesEmpty_FailsValidation()
199199
var results = ValidateModel(options);
200200

201201
// Assert
202-
using var _ = Assert.Multiple();
202+
using var scope = Assert.Multiple();
203203
_ = await Assert.That(results).IsNotEmpty();
204204
_ = await Assert.That(results.Any(r => r.ErrorMessage!.Contains("At least one supported culture"))).IsTrue();
205205
}
@@ -219,7 +219,7 @@ public async Task LocalizationOptions_DefaultCultureNotInSupportedCultures_Fails
219219
var results = ValidateModel(options);
220220

221221
// Assert
222-
using var _ = Assert.Multiple();
222+
using var scope = Assert.Multiple();
223223
_ = await Assert.That(results).Count().IsEqualTo(1);
224224
_ = await Assert.That(results[0].ErrorMessage).Contains("DefaultCulture 'en-US' must be included in SupportedCultures");
225225
}

‎src/ApiService/BookStore.ApiService.Tests/CultureCacheTests.cs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ public async Task IsValidCultureCode_CaseInsensitive_ReturnsTrue()
8080
var result2 = Infrastructure.CultureCache.IsValidCultureCode("PT");
8181

8282
// Assert
83-
using var _ = Assert.Multiple();
83+
using var scope = Assert.Multiple();
8484
_ = await Assert.That(result1).IsTrue();
8585
_ = await Assert.That(result2).IsTrue();
8686
}
@@ -143,7 +143,7 @@ public async Task GetInvalidCodes_SomeInvalid_ReturnsInvalidOnes()
143143
var invalidCodes = Infrastructure.CultureCache.GetInvalidCodes(codes);
144144

145145
// Assert
146-
using var _ = Assert.Multiple();
146+
using var scope = Assert.Multiple();
147147
_ = await Assert.That(invalidCodes).Count().IsEqualTo(2);
148148
_ = await Assert.That(invalidCodes).Contains("xx-XX");
149149
_ = await Assert.That(invalidCodes).Contains("invalid");

‎src/ApiService/BookStore.ApiService.Tests/PartialDateTests.cs‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ public class PartialDateTests
1111
public async Task Constructor_WithYearOnly_SetsProperties()
1212
{
1313
var date = new PartialDate(2023);
14-
using var _ = Assert.Multiple();
14+
using var scope = Assert.Multiple();
1515
_ = await Assert.That(date.Year).IsEqualTo(2023);
1616
_ = await Assert.That(date.Month).IsNull();
1717
_ = await Assert.That(date.Day).IsNull();
@@ -22,7 +22,7 @@ public async Task Constructor_WithYearOnly_SetsProperties()
2222
public async Task Constructor_WithYearMonth_SetsProperties()
2323
{
2424
var date = new PartialDate(2023, 5);
25-
using var _ = Assert.Multiple();
25+
using var scope = Assert.Multiple();
2626
_ = await Assert.That(date.Year).IsEqualTo(2023);
2727
_ = await Assert.That(date.Month).IsEqualTo(5);
2828
_ = await Assert.That(date.Day).IsNull();
@@ -33,7 +33,7 @@ public async Task Constructor_WithYearMonth_SetsProperties()
3333
public async Task Constructor_WithFullDate_SetsProperties()
3434
{
3535
var date = new PartialDate(2023, 5, 15);
36-
using var _ = Assert.Multiple();
36+
using var scope = Assert.Multiple();
3737
_ = await Assert.That(date.Year).IsEqualTo(2023);
3838
_ = await Assert.That(date.Month).IsEqualTo(5);
3939
_ = await Assert.That(date.Day).IsEqualTo(15);
@@ -77,7 +77,7 @@ await Assert.ThrowsAsync<ArgumentOutOfRangeException>(() =>
7777
[Category("Unit")]
7878
public async Task ToString_ReturnsCorrectFormat()
7979
{
80-
using var _ = Assert.Multiple();
80+
using var scope = Assert.Multiple();
8181
_ = await Assert.That(new PartialDate(2023).ToString()).IsEqualTo("2023");
8282
_ = await Assert.That(new PartialDate(2023, 5).ToString()).IsEqualTo("2023-05");
8383
_ = await Assert.That(new PartialDate(2023, 5, 15).ToString()).IsEqualTo("2023-05-15");
@@ -93,7 +93,7 @@ public async Task Serialization_WithYearOnly_ReturnsCorrectJson()
9393
using var document = JsonDocument.Parse(json);
9494
var root = document.RootElement;
9595

96-
using var _ = Assert.Multiple();
96+
using var scope = Assert.Multiple();
9797
_ = await Assert.That(root.GetProperty("year").GetInt32()).IsEqualTo(2023);
9898
_ = await Assert.That(root.TryGetProperty("month", out var unusedMonth)).IsFalse();
9999
_ = await Assert.That(root.TryGetProperty("day", out var unusedDay)).IsFalse();
@@ -109,7 +109,7 @@ public async Task Serialization_WithFullDate_ReturnsCorrectJson()
109109
using var document = JsonDocument.Parse(json);
110110
var root = document.RootElement;
111111

112-
using var _ = Assert.Multiple();
112+
using var scope = Assert.Multiple();
113113
_ = await Assert.That(root.GetProperty("year").GetInt32()).IsEqualTo(2023);
114114
_ = await Assert.That(root.GetProperty("month").GetInt32()).IsEqualTo(5);
115115
_ = await Assert.That(root.GetProperty("day").GetInt32()).IsEqualTo(15);
@@ -141,7 +141,7 @@ public async Task Deserialization_WithYearOnly_ReturnsCorrectObject()
141141
var date = Deserialize(json);
142142

143143
_ = await Assert.That(date).IsNotNull();
144-
using var _ = Assert.Multiple();
144+
using var scope = Assert.Multiple();
145145
_ = await Assert.That(date!.Value.Year).IsEqualTo(2023);
146146
_ = await Assert.That(date!.Value.Month).IsNull();
147147
_ = await Assert.That(date!.Value.Day).IsNull();
@@ -155,7 +155,7 @@ public async Task Deserialization_WithPascalCase_ReturnsCorrectObject()
155155
var date = Deserialize(json);
156156

157157
_ = await Assert.That(date).IsNotNull();
158-
using var _ = Assert.Multiple();
158+
using var scope = Assert.Multiple();
159159
_ = await Assert.That(date!.Value.Year).IsEqualTo(2023);
160160
_ = await Assert.That(date!.Value.Month).IsEqualTo(5);
161161
_ = await Assert.That(date!.Value.Day).IsEqualTo(15);

0 commit comments

Comments
 (0)