refactor: Suppress compiler warnings in test assertions and mock setups using discard assignments.

Author: aalmada

src/ApiService/BookStore.ApiService.Tests/Handlers/BookHandlerTests.cs

@@ -29,14 +29,14 @@ public async Task CreateBookHandler_ShouldStartStreamWithBookAddedEvent()
             [Guid.CreateVersion7()]);
 
         var session = Substitute.For<IDocumentSession>();
-        session.CorrelationId.Returns("test-correlation-id");
+        _ = session.CorrelationId.Returns("test-correlation-id");
 
         // Act
         var result = BookHandlers.Handle(command, session);
 
         // Assert
-        await Assert.That(result.Item1).IsNotNull();
-        session.Events.Received(1).StartStream<BookAggregate>(
+        _ = await Assert.That(result.Item1).IsNotNull();
+        _ = session.Events.Received(1).StartStream<BookAggregate>(
             command.Id,
             Arg.Is<BookAdded>(e => 
                 e.Title == "Clean Code" && 
@@ -62,13 +62,13 @@ public async Task UpdateBookHandler_WithMissingBook_ShouldReturnNotFound()
         var context = new DefaultHttpContext();
 
         // Stream doesn't exist
-        session.Events.FetchStreamStateAsync(command.Id)
+        _ = session.Events.FetchStreamStateAsync(command.Id)
             .Returns(Task.FromResult<Marten.Events.StreamState?>(null));
 
         // Act
         var result = await BookHandlers.Handle(command, session, context);
 
         // Assert
-        await Assert.That(result).IsTypeOf<Microsoft.AspNetCore.Http.HttpResults.NotFound>();
+        _ = await Assert.That(result).IsTypeOf<Microsoft.AspNetCore.Http.HttpResults.NotFound>();
     }
 }

src/ApiService/BookStore.ApiService.Tests/JsonSerializationTests.cs

@@ -32,7 +32,7 @@ public async Task DateTimeOffset_Should_Serialize_As_ISO8601_With_UTC()
         var json = JsonSerializer.Serialize(testObject, _options.Value);
 
         // Assert
-        await Assert.That(json).Contains("\"timestamp\":\"2025-12-26T17:16:09.123+00:00\"");
+        _ = await Assert.That(json).Contains("\"timestamp\":\"2025-12-26T17:16:09.123+00:00\"");
     }
 
     [Test]
@@ -46,7 +46,7 @@ public async Task DateTimeOffset_UtcNow_Should_End_With_Z_Or_UTC_Offset()
         var json = JsonSerializer.Serialize(testObject, _options.Value);
 
         // Assert - Should match ISO 8601 format with UTC indicator
-        await Assert.That(json).Matches(@"""timestamp"":""(\d{4})-(\d{2})-(\d{2})T(\d{2}):(\d{2}):(\d{2})(\.\d+)?\+00:00""");
+        _ = await Assert.That(json).Matches(@"""timestamp"":""(\d{4})-(\d{2})-(\d{2})T(\d{2}):(\d{2}):(\d{2})(\.\d+)?\+00:00\""");
     }
 
     [Test]
@@ -60,7 +60,7 @@ public async Task DateOnly_Should_Serialize_As_ISO8601_Date()
         var json = JsonSerializer.Serialize(testObject, _options.Value);
 
         // Assert
-        await Assert.That(json).Contains("\"publicationDate\":\"2008-08-01\"");
+        _ = await Assert.That(json).Contains("\"publicationDate\":\"2008-08-01\"");
     }
 
     [Test]
@@ -74,8 +74,8 @@ public async Task Enum_Should_Serialize_As_String_Not_Integer()
         var json = JsonSerializer.Serialize(testObject, _options.Value);
 
         // Assert
-        await Assert.That(json).Contains("\"status\":\"active\"");  // camelCase enum value
-        await Assert.That(json).DoesNotContain("\"status\":0");
+        _ = await Assert.That(json).Contains("\"status\":\"active\"");  // camelCase enum value
+        _ = await Assert.That(json).DoesNotContain("\"status\":0");
     }
 
     [Test]
@@ -95,14 +95,14 @@ public async Task Properties_Should_Use_CamelCase()
         var json = JsonSerializer.Serialize(testObject, _options.Value);
 
         // Assert
-        await Assert.That(json).Contains("\"bookId\":");
-        await Assert.That(json).Contains("\"bookTitle\":");
-        await Assert.That(json).Contains("\"publicationDate\":");
-        await Assert.That(json).Contains("\"lastModified\":");
+        _ = await Assert.That(json).Contains("\"bookId\":");
+        _ = await Assert.That(json).Contains("\"bookTitle\":");
+        _ = await Assert.That(json).Contains("\"publicationDate\":");
+        _ = await Assert.That(json).Contains("\"lastModified\":");
 
         // Should NOT contain PascalCase
-        await Assert.That(json).DoesNotContain("\"BookId\":");
-        await Assert.That(json).DoesNotContain("\"BookTitle\":");
+        _ = await Assert.That(json).DoesNotContain("\"BookId\":");
+        _ = await Assert.That(json).DoesNotContain("\"BookTitle\":");
     }
 
     [Test]
@@ -124,15 +124,15 @@ public async Task Complex_Object_Should_Follow_All_Standards()
 
         // Assert
         // camelCase properties
-        await Assert.That(json).Contains("\"bookId\":");
-        await Assert.That(json).Contains("\"bookTitle\":");
+        _ = await Assert.That(json).Contains("\"bookId\":");
+        _ = await Assert.That(json).Contains("\"bookTitle\":");
 
         // ISO 8601 dates
-        await Assert.That(json).Contains("\"publicationDate\":\"2008-08-01\"");
-        await Assert.That(json).Contains("\"lastModified\":\"2025-12-26T17:16:09+00:00\"");
+        _ = await Assert.That(json).Contains("\"publicationDate\":\"2008-08-01\"");
+        _ = await Assert.That(json).Contains("\"lastModified\":\"2025-12-26T17:16:09+00:00\"");
 
         // Enum as string
-        await Assert.That(json).Contains("\"status\":\"active\"");
+        _ = await Assert.That(json).Contains("\"status\":\"active\"");
     }
 
     // Test DTOs