refactor: improve test assertion clarity by using discard assignments for await results and named multiple assertion scopes.

Author: aalmada

src/ApiService/BookStore.ApiService.Tests/ConfigurationValidationTests.cs

@@ -41,9 +41,9 @@ public async Task PaginationOptions_DefaultPageSizeNegative_FailsValidation()
         var results = ValidateModel(options);
 
         // Assert
-        using var _ = Assert.Multiple();
-        await Assert.That(results).Count().IsEqualTo(1);
-        await Assert.That(results[0].ErrorMessage).Contains("DefaultPageSize must be between 1 and 1000");
+        using var scope = Assert.Multiple();
+        _ = await Assert.That(results).Count().IsEqualTo(1);
+        _ = await Assert.That(results[0].ErrorMessage).Contains("DefaultPageSize must be between 1 and 1000");
     }
 
     [Test]
@@ -62,8 +62,8 @@ public async Task PaginationOptions_DefaultPageSizeZero_FailsValidation()
 
         // Assert
         using var scope = Assert.Multiple();
-        await Assert.That(results).Count().IsEqualTo(1);
-        await Assert.That(results[0].ErrorMessage).Contains("DefaultPageSize must be between 1 and 1000");
+        _ = await Assert.That(results).Count().IsEqualTo(1);
+        _ = await Assert.That(results[0].ErrorMessage).Contains("DefaultPageSize must be between 1 and 1000");
     }
 
     [Test]
@@ -81,9 +81,9 @@ public async Task PaginationOptions_DefaultPageSizeTooLarge_FailsValidation()
         var results = ValidateModel(options);
 
         // Assert
-        using var _ = Assert.Multiple();
-        await Assert.That(results).Count().IsGreaterThanOrEqualTo(1);
-        await Assert.That(results.Any(r => r.ErrorMessage!.Contains("DefaultPageSize must be between 1 and 1000"))).IsTrue();
+        using var scope = Assert.Multiple();
+        _ = await Assert.That(results).Count().IsGreaterThanOrEqualTo(1);
+        _ = await Assert.That(results.Any(r => r.ErrorMessage!.Contains("DefaultPageSize must be between 1 and 1000"))).IsTrue();
     }
 
     [Test]
@@ -102,8 +102,8 @@ public async Task PaginationOptions_MaxPageSizeNegative_FailsValidation()
 
         // Assert
         using var scope = Assert.Multiple();
-        await Assert.That(results).Count().IsEqualTo(1);
-        await Assert.That(results[0].ErrorMessage).Contains("MaxPageSize must be between 1 and 1000");
+        _ = await Assert.That(results).Count().IsEqualTo(1);
+        _ = await Assert.That(results[0].ErrorMessage).Contains("MaxPageSize must be between 1 and 1000");
     }
 
     [Test]
@@ -122,8 +122,8 @@ public async Task PaginationOptions_MaxPageSizeZero_FailsValidation()
 
         // Assert
         using var scope = Assert.Multiple();
-        await Assert.That(results).Count().IsEqualTo(1);
-        await Assert.That(results[0].ErrorMessage).Contains("MaxPageSize must be between 1 and 1000");
+        _ = await Assert.That(results).Count().IsEqualTo(1);
+        _ = await Assert.That(results[0].ErrorMessage).Contains("MaxPageSize must be between 1 and 1000");
     }
 
     [Test]
@@ -141,9 +141,9 @@ public async Task PaginationOptions_DefaultPageSizeGreaterThanMaxPageSize_FailsV
         var results = ValidateModel(options);
 
         // Assert
-        using var _ = Assert.Multiple();
-        await Assert.That(results).Count().IsEqualTo(1);
-        await Assert.That(results[0].ErrorMessage).Contains("DefaultPageSize (100) cannot be greater than MaxPageSize (50)");
+        using var scope = Assert.Multiple();
+        _ = await Assert.That(results).Count().IsEqualTo(1);
+        _ = await Assert.That(results[0].ErrorMessage).Contains("DefaultPageSize (100) cannot be greater than MaxPageSize (50)");
     }
 
     [Test]
@@ -161,7 +161,7 @@ public async Task LocalizationOptions_ValidConfiguration_PassesValidation()
         var results = ValidateModel(options);
 
         // Assert
-        await Assert.That(results).IsEmpty();
+        _ = await Assert.That(results).IsEmpty();
     }
 
     [Test]
@@ -179,9 +179,9 @@ public async Task LocalizationOptions_DefaultCultureEmpty_FailsValidation()
         var results = ValidateModel(options);
 
         // Assert
-        using var _ = Assert.Multiple();
-        await Assert.That(results).IsNotEmpty();
-        await Assert.That(results.Any(r => r.ErrorMessage!.Contains("DefaultCulture"))).IsTrue();
+        using var scope = Assert.Multiple();
+        _ = await Assert.That(results).IsNotEmpty();
+        _ = await Assert.That(results.Any(r => r.ErrorMessage!.Contains("DefaultCulture"))).IsTrue();
     }
 
 [Test]
@@ -199,9 +199,9 @@ public async Task LocalizationOptions_SupportedCulturesEmpty_FailsValidation()
         var results = ValidateModel(options);
 
         // Assert
-        using var _ = Assert.Multiple();
-        await Assert.That(results).IsNotEmpty();
-        await Assert.That(results.Any(r => r.ErrorMessage!.Contains("At least one supported culture"))).IsTrue();
+        using var scope = Assert.Multiple();
+        _ = await Assert.That(results).IsNotEmpty();
+        _ = await Assert.That(results.Any(r => r.ErrorMessage!.Contains("At least one supported culture"))).IsTrue();
     }
 
 [Test]
@@ -219,9 +219,9 @@ public async Task LocalizationOptions_DefaultCultureNotInSupportedCultures_Fails
         var results = ValidateModel(options);
 
         // Assert
-        using var _ = Assert.Multiple();
-        await Assert.That(results).Count().IsEqualTo(1);
-        await Assert.That(results[0].ErrorMessage).Contains("DefaultCulture 'en-US' must be included in SupportedCultures");
+        using var scope = Assert.Multiple();
+        _ = await Assert.That(results).Count().IsEqualTo(1);
+        _ = await Assert.That(results[0].ErrorMessage).Contains("DefaultCulture 'en-US' must be included in SupportedCultures");
     }
 
     [Test]
@@ -239,7 +239,7 @@ public async Task LocalizationOptions_DefaultCultureInSupportedCulturesCaseInsen
         var results = ValidateModel(options);
 
         // Assert
-        await Assert.That(results).IsEmpty();
+        _ = await Assert.That(results).IsEmpty();
     }
 
     /// <summary>

src/ApiService/BookStore.ApiService.Tests/CultureCacheTests.cs

@@ -80,9 +80,9 @@ public async Task IsValidCultureCode_CaseInsensitive_ReturnsTrue()
         var result2 = Infrastructure.CultureCache.IsValidCultureCode("PT");
 
         // Assert
-        using var _ = Assert.Multiple();
-        await Assert.That(result1).IsTrue();
-        await Assert.That(result2).IsTrue();
+        using var scope = Assert.Multiple();
+        _ = await Assert.That(result1).IsTrue();
+        _ = await Assert.That(result2).IsTrue();
     }
 
     [Test]
@@ -143,10 +143,10 @@ public async Task GetInvalidCodes_SomeInvalid_ReturnsInvalidOnes()
         var invalidCodes = Infrastructure.CultureCache.GetInvalidCodes(codes);
 
         // Assert
-        using var _ = Assert.Multiple();
-        await Assert.That(invalidCodes).Count().IsEqualTo(2);
-        await Assert.That(invalidCodes).Contains("xx-XX");
-        await Assert.That(invalidCodes).Contains("invalid");
+        using var scope = Assert.Multiple();
+        _ = await Assert.That(invalidCodes).Count().IsEqualTo(2);
+        _ = await Assert.That(invalidCodes).Contains("xx-XX");
+        _ = await Assert.That(invalidCodes).Contains("invalid");
     }
 
     [Test]