refactor: consolidate command namespaces and enforce stricter aggregate immutability

Author: aalmada

Directory.Build.props

@@ -4,7 +4,7 @@
     <LangVersion>latest</LangVersion>
     <Nullable>enable</Nullable>
     <ImplicitUsings>enable</ImplicitUsings>
-    <TreatWarningsAsErrors>false</TreatWarningsAsErrors>
+    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild>
   </PropertyGroup>
 

src/ApiService/BookStore.ApiService.Analyzers/BookStore.ApiService.Analyzers.csproj

@@ -4,6 +4,7 @@
     <TargetFramework>netstandard2.0</TargetFramework>
     <IsPackable>false</IsPackable>
     <EnforceExtendedAnalyzerRules>true</EnforceExtendedAnalyzerRules>
+    <NoWarn>$(NoWarn);RS2008</NoWarn>
   </PropertyGroup>
 
   <ItemGroup>

src/ApiService/BookStore.ApiService/Aggregates/AuthorAggregate.cs

@@ -4,10 +4,10 @@ namespace BookStore.ApiService.Aggregates;
 
 public class AuthorAggregate
 {
-    public Guid Id { get; set; }
-    public string Name { get; set; } = string.Empty;
-    public string? Biography { get; set; }
-    public bool IsDeleted { get; set; }
+    public Guid Id { get; private set; }
+    public string Name { get; private set; } = string.Empty;
+    public string? Biography { get; private set; }
+    public bool IsDeleted { get; private set; }
 
     // Marten uses this for rehydration
     void Apply(AuthorAdded @event)

src/ApiService/BookStore.ApiService/Aggregates/BookAggregate.cs

@@ -5,15 +5,15 @@ namespace BookStore.ApiService.Aggregates;
 
 public class BookAggregate
 {
-    public Guid Id { get; set; }
-    public string Title { get; set; } = string.Empty;
-    public string? Isbn { get; set; }
-    public string? Description { get; set; }
-    public DateOnly? PublicationDate { get; set; }
-    public Guid? PublisherId { get; set; }
-    public List<Guid> AuthorIds { get; set; } = [];
-    public List<Guid> CategoryIds { get; set; } = [];
-    public bool IsDeleted { get; set; }
+    public Guid Id { get; private set; }
+    public string Title { get; private set; } = string.Empty;
+    public string? Isbn { get; private set; }
+    public string? Description { get; private set; }
+    public DateOnly? PublicationDate { get; private set; }
+    public Guid? PublisherId { get; private set; }
+    public List<Guid> AuthorIds { get; private set; } = [];
+    public List<Guid> CategoryIds { get; private set; } = [];
+    public bool IsDeleted { get; private set; }
 
     // Marten uses this for rehydration
     void Apply(BookAdded @event)

src/ApiService/BookStore.ApiService/Aggregates/CategoryAggregate.cs

@@ -4,11 +4,11 @@ namespace BookStore.ApiService.Aggregates;
 
 public class CategoryAggregate
 {
-    public Guid Id { get; set; }
-    public string Name { get; set; } = string.Empty;
-    public string? Description { get; set; }
-    public Dictionary<string, CategoryTranslation> Translations { get; set; } = [];
-    public bool IsDeleted { get; set; }
+    public Guid Id { get; private set; }
+    public string Name { get; private set; } = string.Empty;
+    public string? Description { get; private set; }
+    public Dictionary<string, CategoryTranslation> Translations { get; private set; } = [];
+    public bool IsDeleted { get; private set; }
 
     // Marten uses this for rehydration
     void Apply(CategoryAdded @event)

src/ApiService/BookStore.ApiService/Aggregates/PublisherAggregate.cs

@@ -4,9 +4,9 @@ namespace BookStore.ApiService.Aggregates;
 
 public class PublisherAggregate
 {
-    public Guid Id { get; set; }
-    public string Name { get; set; } = string.Empty;
-    public bool IsDeleted { get; set; }
+    public Guid Id { get; private set; }
+    public string Name { get; private set; } = string.Empty;
+    public bool IsDeleted { get; private set; }
 
     // Marten uses this for rehydration
     void Apply(PublisherAdded @event)

src/ApiService/BookStore.ApiService/Commands/Authors/AuthorCommands.cs

@@ -1,4 +1,4 @@
-namespace BookStore.ApiService.Commands.Authors;
+namespace BookStore.ApiService.Commands;
 
 /// <summary>
 /// Command to create a new author

src/ApiService/BookStore.ApiService/Commands/Books/BookCommands.cs

@@ -1,4 +1,4 @@
-namespace BookStore.ApiService.Commands.Books;
+namespace BookStore.ApiService.Commands;
 
 /// <summary>
 /// Command to create a new book

src/ApiService/BookStore.ApiService/Commands/Categories/CategoryCommands.cs

@@ -1,4 +1,4 @@
-namespace BookStore.ApiService.Commands.Categories;
+namespace BookStore.ApiService.Commands;
 
 /// <summary>
 /// Command to create a new category

src/ApiService/BookStore.ApiService/Commands/Publishers/PublisherCommands.cs

@@ -1,4 +1,4 @@
-namespace BookStore.ApiService.Commands.Publishers;
+namespace BookStore.ApiService.Commands;
 
 /// <summary>
 /// Command to create a new publisher