Fixed broken promise chain#61
Open
matteopic wants to merge 107 commits into
Open
Conversation
added 30 commits
March 16, 2023 21:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #60.
The message reported happens because the Svx3dLoader parses the .3d files in two steps; first calling method parse(), then calling parse2().
Survey class performs the following check after the model has been loaded:
If the model has an init value equal to
epsg:27700the loading works correctly because there is a piece of sync code that handle it, but if it is different then a fetch to https://epsg.io site starts.The absence of return inside the Svx3dLoader.load cause the promise chain to break and when the async call to https://epsg.io begin, the execution continues even though the model has not fully loaded.