Heroku button#57
Open
Lewiscowles1986 wants to merge 3 commits into
Open
Conversation
Lewiscowles1986
force-pushed
the
heroku-button
branch
4 times, most recently
from
48d928c to
73c66eb
Compare
Contributor
Author
|
#43 closed |
aaronpk
requested changes
Jan 29, 2020
Owner
aaronpk
left a comment
aaronpk
left a comment
There was a problem hiding this comment.
Looks good! Just a couple minor questions.
Lewiscowles1986
force-pushed
the
heroku-button
branch
from
73c66eb to
7a4a2a6
Compare
Lewiscowles1986
force-pushed
the
heroku-button
branch
4 times, most recently
from
678422e to
7a8856c
Compare
Lewiscowles1986
force-pushed
the
heroku-button
branch
from
7a8856c to
e098977
Compare
Contributor
Author
|
Oh, I went to link this and it seems there is work to do. I'd forgotten and assumed it had merged at same time as meetable. Was there something both of us were waiting for / expecting? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a re-take on a heroku deploy button.
A sample deploy is available at https://indielogin-lc-2020.herokuapp.com/
Important changes are that it does not require (but can still accept)
DB_NAMEDB_HOSTDB_USERDB_PASSIt introduces
setupDBandinstallDBmethods. This can take the above ENV; or also take certain heroku and cloud-familiarENVsuch asJAWSDBand / orCLEARDB_DATABASE_URL, orDATABASE_URL. This can be set by literal machine / user ENV or dotenv.Migrating on release / update... Right now it's manual commands against the heroku mysql resource.
Adds logging changes so that if someone deploys this to more than one host they can aggregate using papertrail or similar syslog parser.
Also adds a release script which sets up database