Fix #98.

While one command is waiting on the jobs semaphore, another command can fail.  Need to check exit on error condiition after acquiring semaphore.

Author: aaronriekenberg

src/command.rs

@@ -141,11 +141,6 @@ impl CommandService {
             return Ok(());
         }
 
-        if self.command_line_args.exit_on_error && self.context.command_metrics.error_occurred() {
-            trace!("return from spawn_command due to exit_on_error");
-            return Ok(());
-        }
-
         let context_clone = Arc::clone(&self.context);
 
         let output_sender = self.output_writer.sender();
@@ -155,6 +150,11 @@ impl CommandService {
             .await
             .context("command_semaphore.acquire_owned error")?;
 
+        if self.command_line_args.exit_on_error && self.context.command_metrics.error_occurred() {
+            trace!("return from spawn_command due to exit_on_error");
+            return Ok(());
+        }
+
         tokio::spawn(async move {
             command.run(&context_clone, output_sender).await;
 

tests/integration_tests.rs

@@ -603,7 +603,7 @@ fn test_exit_status_on_failing_commands_exit_on_error() {
         .failure()
         .code(1)
         .stdout(
-            (predicate::str::contains("command failed"))
+            (predicate::str::contains("command failed").count(1))
                 .and(predicate::str::contains("command failures:"))
                 .and(predicate::str::contains("exit_status_errors=0").not()),
         )