fix(schema): make migration 058 and runner resilient to AGE cold start

058 uses AGE Cypher DDL (CREATE VLABEL/ELABEL) which can fail on cold
start when AGE isn't fully initialized. Wrap each label creation in
EXCEPTION handler so failures log a notice instead of aborting — labels
get created on first use anyway.

Also add ON_ERROR_STOP=1 to psql in migrate-db.sh so failed migrations
don't self-register via the INSERT at the end of the file. Previously,
a mid-file failure would still record the migration as applied, then
the runner would exit, blocking all subsequent migrations.

Author: aaronsb

operator/database/migrate-db.sh

@@ -43,7 +43,7 @@ if [ -f "/.dockerenv" ] || grep -q docker /proc/1/cgroup 2>/dev/null; then
         PGPASSWORD="${POSTGRES_PASSWORD}" psql -h "$DB_HOST" -U "$DB_USER" -d "$DB_NAME" "$@"
     }
     run_psql_file() {
-        PGPASSWORD="${POSTGRES_PASSWORD}" psql -h "$DB_HOST" -U "$DB_USER" -d "$DB_NAME" -f "$1"
+        PGPASSWORD="${POSTGRES_PASSWORD}" psql -h "$DB_HOST" -U "$DB_USER" -d "$DB_NAME" -v ON_ERROR_STOP=1 -f "$1"
     }
 else
     INSIDE_CONTAINER=false
@@ -52,7 +52,7 @@ else
         docker exec "$CONTAINER" psql -U "$DB_USER" -d "$DB_NAME" "$@"
     }
     run_psql_file() {
-        docker exec -i "$CONTAINER" psql -U "$DB_USER" -d "$DB_NAME" < "$1"
+        docker exec -i "$CONTAINER" psql -U "$DB_USER" -d "$DB_NAME" -v ON_ERROR_STOP=1 < "$1"
     }
 fi
 

schema/migrations/058_precreate_graph_labels.sql

@@ -8,6 +8,9 @@
 -- Fix: explicitly create all known vertex and edge labels at schema init time.
 -- Uses DO blocks to check ag_catalog.ag_label before creating (AGE has no
 -- CREATE VLABEL IF NOT EXISTS syntax).
+--
+-- Note: Uses EXCEPTION handlers so label creation failures (e.g., AGE not fully
+-- initialized on cold start) are logged as warnings rather than aborting the migration.
 
 LOAD 'age';
 SET search_path = ag_catalog, "$user", public;
@@ -27,11 +30,15 @@ BEGIN
             JOIN ag_catalog.ag_graph g ON l.graph = g.graphid
             WHERE g.name = 'knowledge_graph' AND l.name = lbl AND l.kind = 'v'
         ) THEN
-            EXECUTE format(
-                'SELECT * FROM cypher(''knowledge_graph'', $$ CREATE VLABEL %I $$) as (a agtype)',
-                lbl
-            );
-            RAISE NOTICE 'Created vertex label: %', lbl;
+            BEGIN
+                EXECUTE format(
+                    'SELECT * FROM cypher(''knowledge_graph'', $$ CREATE VLABEL %I $$) as (a agtype)',
+                    lbl
+                );
+                RAISE NOTICE 'Created vertex label: %', lbl;
+            EXCEPTION WHEN OTHERS THEN
+                RAISE NOTICE 'Could not create vertex label % (will be created on first use): %', lbl, SQLERRM;
+            END;
         END IF;
     END LOOP;
 END $$;
@@ -55,11 +62,15 @@ BEGIN
             JOIN ag_catalog.ag_graph g ON l.graph = g.graphid
             WHERE g.name = 'knowledge_graph' AND l.name = lbl AND l.kind = 'e'
         ) THEN
-            EXECUTE format(
-                'SELECT * FROM cypher(''knowledge_graph'', $$ CREATE ELABEL %I $$) as (a agtype)',
-                lbl
-            );
-            RAISE NOTICE 'Created edge label: %', lbl;
+            BEGIN
+                EXECUTE format(
+                    'SELECT * FROM cypher(''knowledge_graph'', $$ CREATE ELABEL %I $$) as (a agtype)',
+                    lbl
+                );
+                RAISE NOTICE 'Created edge label: %', lbl;
+            EXCEPTION WHEN OTHERS THEN
+                RAISE NOTICE 'Could not create edge label % (will be created on first use): %', lbl, SQLERRM;
+            END;
         END IF;
     END LOOP;
 END $$;
@@ -98,11 +109,15 @@ BEGIN
             JOIN ag_catalog.ag_graph g ON l.graph = g.graphid
             WHERE g.name = 'knowledge_graph' AND l.name = lbl AND l.kind = 'e'
         ) THEN
-            EXECUTE format(
-                'SELECT * FROM cypher(''knowledge_graph'', $$ CREATE ELABEL %I $$) as (a agtype)',
-                lbl
-            );
-            RAISE NOTICE 'Created edge label: %', lbl;
+            BEGIN
+                EXECUTE format(
+                    'SELECT * FROM cypher(''knowledge_graph'', $$ CREATE ELABEL %I $$) as (a agtype)',
+                    lbl
+                );
+                RAISE NOTICE 'Created edge label: %', lbl;
+            EXCEPTION WHEN OTHERS THEN
+                RAISE NOTICE 'Could not create edge label % (will be created on first use): %', lbl, SQLERRM;
+            END;
         END IF;
     END LOOP;
 END $$;