Honor includeUnresolved for graph forward links#206
Merged
Conversation
aaronsb
added
the
area:graph
… contract PR aaronsb#207 (merged 2026-05-25) switched forwardlinks node titling from `file.name.replace(/\.md$/, '')` to `getNodeTitle(file)`, which reads `file.basename`. This PR was authored before that landed, so the test mock set `name` but not `basename` and now produces `title: undefined` on integration. Add `basename` to the mock to match the real TFile API.
aaronsb
force-pushed
the
fix/forwardlinks-include-unresolved
branch
from
4bac854 to
943de66
Compare
Owner
|
Reviewed and merging — thanks for the contribution! Pushed one follow-up commit (943de66) to update the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
includeUnresolvedis exposed as an option for graph operations, butgraph.forwardlinksonly returned resolved links.This updates forward-links handling so:
includeUnresolved: trueadds unresolved outgoing links as graph edgesTFilemetadataCache.unresolvedLinksis handled defensivelyTests
npm run lint(passes with existing warnings)npm run buildnpm test -- tests/graph-search.test.ts --runInBandnpm test -- --runInBand --forceExit