Skip to content

Commit ebc626e

Browse files
committed
Fixes failing tests
1 parent 47ef554 commit ebc626e

8 files changed

Lines changed: 40 additions & 6 deletions

File tree

  • basyx.aasservice/basyx.aasservice-feature-mqtt/src/test/java/org/eclipse/digitaltwin/basyx/aasservice/feature/mqtt
  • basyx.submodelregistry/basyx.submodelregistry-service-basetests/src/main/java/org/eclipse/digitaltwin/basyx/submodelregistry/service/tests/integration
  • basyx.submodelrepository

basyx.aasservice/basyx.aasservice-feature-mqtt/src/test/java/org/eclipse/digitaltwin/basyx/aasservice/feature/mqtt/TestMqttAasService.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,8 @@
4646
import org.eclipse.digitaltwin.basyx.aasservice.backend.InMemoryAasBackend;
4747
import org.eclipse.digitaltwin.basyx.common.mqttcore.encoding.URLEncoder;
4848
import org.eclipse.digitaltwin.basyx.common.mqttcore.listener.MqttTestListener;
49-
import org.eclipse.digitaltwin.basyx.core.filerepository.FileMetadata;
5049
import org.eclipse.digitaltwin.basyx.core.filerepository.FileRepository;
50+
import org.eclipse.digitaltwin.basyx.core.filerepository.FileRepositoryHelper;
5151
import org.eclipse.digitaltwin.basyx.core.filerepository.InMemoryFileRepository;
5252
import org.eclipse.digitaltwin.basyx.http.Aas4JHTTPSerializationExtension;
5353
import org.eclipse.digitaltwin.basyx.http.BaSyxHTTPConfiguration;
@@ -109,9 +109,7 @@ protected AasService getAasServiceWithThumbnail() throws IOException {
109109
AssetAdministrationShell expected = DummyAssetAdministrationShellFactory.createForThumbnail();
110110
AasService aasServiceWithThumbnail = getAasService(expected);
111111

112-
FileMetadata defaultThumbnail = new FileMetadata("dummyImgA.jpeg", "", createDummyImageIS_A());
113-
114-
String thumbnailFilePath = fileRepository.save(defaultThumbnail);
112+
String thumbnailFilePath = FileRepositoryHelper.saveOrOverwriteFile(fileRepository, "dummyImgA.jpeg", "", createDummyImageIS_A());
115113

116114
Resource defaultResource = new DefaultResource.Builder().path(thumbnailFilePath).contentType("").build();
117115
AssetInformation defaultAasAssetInformation = aasServiceWithThumbnail.getAssetInformation();

basyx.submodelregistry/basyx.submodelregistry-service-basetests/src/main/java/org/eclipse/digitaltwin/basyx/submodelregistry/service/tests/integration/BaseIntegrationTest.java

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -143,8 +143,14 @@ protected void cleanup() throws ApiException, InterruptedException, Deserializat
143143
adapter.assertNoAdditionalMessages();
144144
GetSubmodelDescriptorsResult result = api.getAllSubmodelDescriptors(null, null);
145145
for (SubmodelDescriptor eachDescriptor : result.getResult()) {
146-
api.deleteSubmodelDescriptorById(eachDescriptor.getId());
147-
assertThatEventWasSend(RegistryEvent.builder().id(eachDescriptor.getId()).type(EventType.SUBMODEL_UNREGISTERED).build());
146+
try {
147+
api.deleteSubmodelDescriptorById(eachDescriptor.getId());
148+
assertThatEventWasSend(RegistryEvent.builder().id(eachDescriptor.getId()).type(EventType.SUBMODEL_UNREGISTERED).build());
149+
} catch (ApiException e) {
150+
if (e.getCode() != NOT_FOUND) {
151+
throw e;
152+
}
153+
}
148154
}
149155
}
150156

basyx.submodelrepository/basyx.submodelrepository-feature-authorization/src/main/java/org/eclipse/digitaltwin/basyx/submodelrepository/feature/authorization/AuthorizedSubmodelRepository.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -309,6 +309,11 @@ public InputStream getFileByFilePath(String submodelId, String filePath) {
309309
return decorated.getFileByFilePath(submodelId, filePath);
310310
}
311311

312+
@Override
313+
public String getOriginalFileNameByPath(String submodelId, String idShortPath) {
314+
return decorated.getOriginalFileNameByPath(submodelId, idShortPath);
315+
}
316+
312317
private List<String> getIdAsList(String id) {
313318
return new ArrayList<>(Arrays.asList(id));
314319
}

basyx.submodelrepository/basyx.submodelrepository-feature-kafka/src/main/java/org/eclipse/digitaltwin/basyx/submodelrepository/feature/kafka/KafkaSubmodelRepository.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -196,6 +196,11 @@ public InputStream getFileByFilePath(String submodelId, String filePath) {
196196
return decorated.getFileByFilePath(submodelId, filePath);
197197
}
198198

199+
@Override
200+
public String getOriginalFileNameByPath(String submodelId, String idShortPath) {
201+
return decorated.getOriginalFileNameByPath(submodelId, idShortPath);
202+
}
203+
199204
@Override
200205
public CursorResult<List<Submodel>> getAllSubmodels(String semanticId, PaginationInfo pInfo) {
201206
return decorated.getAllSubmodels(semanticId, pInfo);

basyx.submodelrepository/basyx.submodelrepository-feature-mqtt/src/main/java/org/eclipse/digitaltwin/basyx/submodelrepository/feature/mqtt/MqttSubmodelRepository.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -202,6 +202,11 @@ public InputStream getFileByFilePath(String submodelId, String filePath) {
202202
return decorated.getFileByFilePath(submodelId, filePath);
203203
}
204204

205+
@Override
206+
public String getOriginalFileNameByPath(String submodelId, String idShortPath) {
207+
return decorated.getOriginalFileNameByPath(submodelId, idShortPath);
208+
}
209+
205210
private void submodelCreated(Submodel submodel, String repoId) {
206211
sendMqttMessage(topicFactory.createCreateSubmodelTopic(repoId), SubmodelSerializer.serializeSubmodel(submodel));
207212
}

basyx.submodelrepository/basyx.submodelrepository-feature-operation-delegation/src/main/java/org/eclipse/digitaltwin/basyx/submodelrepository/feature/operation/delegation/OperationDelegationSubmodelRepository.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -184,4 +184,9 @@ public InputStream getFileByFilePath(String submodelId, String filePath) {
184184
return decorated.getFileByFilePath(submodelId, filePath);
185185
}
186186

187+
@Override
188+
public String getOriginalFileNameByPath(String submodelId, String idShortPath) {
189+
return decorated.getOriginalFileNameByPath(submodelId, idShortPath);
190+
}
191+
187192
}

basyx.submodelrepository/basyx.submodelrepository-feature-registry-integration/src/main/java/org/eclipse/digitaltwin/basyx/submodelrepository/feature/registry/integration/RegistryIntegrationSubmodelRepository.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -233,4 +233,9 @@ public InputStream getFileByFilePath(String submodelId, String filePath) {
233233
return decorated.getFileByFilePath(submodelId, filePath);
234234
}
235235

236+
@Override
237+
public String getOriginalFileNameByPath(String submodelId, String idShortPath) {
238+
return decorated.getOriginalFileNameByPath(submodelId, idShortPath);
239+
}
240+
236241
}

basyx.submodelrepository/basyx.submodelrepository-feature-search/src/main/java/org/eclipse/digitaltwin/basyx/submodelrepository/feature/search/SearchSubmodelRepository.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -183,6 +183,11 @@ public InputStream getFileByFilePath(String submodelId, String filePath) {
183183
return decorated.getFileByFilePath(submodelId, filePath);
184184
}
185185

186+
@Override
187+
public String getOriginalFileNameByPath(String submodelId, String idShortPath) {
188+
return decorated.getOriginalFileNameByPath(submodelId, idShortPath);
189+
}
190+
186191
private void indexSM(Submodel submodel) {
187192
try {
188193
JsonNode normalizedSubmodel = IndexNormalizer.toIndexable(submodel);

0 commit comments

Comments
 (0)