Skip to content

Commit 13752e6

Browse files
authored
Merge pull request #3 from abap2UI5-addons/claude/charming-archimedes-95rvpx
Refactor z2ui5_cl_sel_var_db: Remove unused methods and simplify
2 parents 2573527 + 46c4c7f commit 13752e6

1 file changed

Lines changed: 2 additions & 80 deletions

File tree

src/01/z2ui5_cl_sel_var_db.clas.abap

Lines changed: 2 additions & 80 deletions
Original file line numberDiff line numberDiff line change
@@ -3,34 +3,9 @@ CLASS z2ui5_cl_sel_var_db DEFINITION
33
CREATE PUBLIC.
44

55
PUBLIC SECTION.
6-
CLASS-METHODS factory
7-
IMPORTING
8-
report TYPE string
9-
RETURNING
10-
VALUE(result) TYPE REF TO z2ui5_cl_sel_var_db.
11-
126
TYPES ty_s_db TYPE z2ui5_t_13.
13-
* TYPES ty_s_pos TYPE z2ui5_t_14.
14-
15-
DATA mt_variant TYPE STANDARD TABLE OF ty_s_db WITH EMPTY KEY.
16-
17-
METHODS check_default.
18-
METHODS get_default.
19-
207
TYPES ty_t_db TYPE STANDARD TABLE OF z2ui5_t_13 WITH EMPTY KEY.
218

22-
METHODS db_variant_read
23-
IMPORTING
24-
name TYPE string
25-
RETURNING
26-
VALUE(result) TYPE z2ui5_cl_util=>ty_t_filter_multi.
27-
28-
METHODS db_variant_save
29-
IMPORTING
30-
name TYPE string
31-
RETURNING
32-
VALUE(result) TYPE z2ui5_cl_util=>ty_t_filter_multi.
33-
349
CLASS-METHODS db_read_default
3510
IMPORTING
3611
s_info TYPE z2ui5_t_13
@@ -49,35 +24,12 @@ CLASS z2ui5_cl_sel_var_db DEFINITION
4924
data TYPE data.
5025

5126
PROTECTED SECTION.
52-
DATA:
53-
BEGIN OF mS_config,
54-
classname TYPE string,
55-
name TYPE string,
56-
user TYPE string,
57-
timestamp TYPE timestamp,
58-
data TYPE string,
59-
END OF mS_config.
60-
61-
DATA object TYPE REF TO object.
62-
DATA mt_filter TYPE z2ui5_cl_util=>ty_t_filter_multi.
63-
64-
METHODS obj_to_filter.
65-
METHODS filter_to_object.
66-
6727
PRIVATE SECTION.
6828
ENDCLASS.
6929

7030

7131
CLASS z2ui5_cl_sel_var_db IMPLEMENTATION.
7232

73-
METHOD obj_to_filter.
74-
75-
ENDMETHOD.
76-
77-
METHOD filter_to_object.
78-
79-
ENDMETHOD.
80-
8133
METHOD db_read.
8234

8335
SELECT FROM z2ui5_t_13
@@ -100,33 +52,6 @@ CLASS z2ui5_cl_sel_var_db IMPLEMENTATION.
10052

10153
ENDMETHOD.
10254

103-
METHOD factory.
104-
105-
result = NEW #( ).
106-
107-
* SELECT FROM z2ui5_t_13
108-
* FIELDS *
109-
* WHERE classname = @report
110-
* INTO TABLE @result->mt_variant.
111-
112-
ENDMETHOD.
113-
114-
METHOD check_default.
115-
116-
ENDMETHOD.
117-
118-
METHOD db_variant_read.
119-
120-
ENDMETHOD.
121-
122-
METHOD get_default.
123-
124-
ENDMETHOD.
125-
126-
METHOD db_variant_save.
127-
128-
ENDMETHOD.
129-
13055
METHOD db_read_default.
13156

13257
IF s_info-uname IS INITIAL.
@@ -150,13 +75,10 @@ CLASS z2ui5_cl_sel_var_db IMPLEMENTATION.
15075
SELECT SINGLE FROM z2ui5_t_13
15176
FIELDS
15277
*
153-
WHERE
154-
* uname = @s_info-uname AND
155-
handle01 = @s_info-handle01 AND
156-
check_def = @abap_true
78+
WHERE handle01 = @s_info-handle01
79+
AND check_def = @abap_true
15780
INTO @result.
15881

159-
16082
ENDMETHOD.
16183

16284
ENDCLASS.

0 commit comments

Comments
 (0)