Skip to content

Commit 281b13b

Browse files
committed
Remove dead code and tidy config
- Remove unused method preview_filter_range - Drop unused parameters fw_table/fw_title from result_display - Remove misleading DEFAULT sy-uname from db_read_by_id (id, not user) - Normalize default query casing to SELECT * FROM t100 - Quote node-version in workflows, extend .gitignore, add engines to package.json Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MEGSbezJEiFoFubnrqATiM
1 parent 9cf6fa4 commit 281b13b

8 files changed

Lines changed: 14 additions & 27 deletions

File tree

.github/workflows/ABAP_CLOUD.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ jobs:
2020
- uses: actions/checkout@v5
2121
- uses: actions/setup-node@v5
2222
with:
23-
node-version: 22
23+
node-version: '22'
2424
cache: 'npm'
2525
- run: npm ci
2626
- run: npx abaplint .github/abaplint/abap_cloud.jsonc

.github/workflows/ABAP_STANDARD.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ jobs:
2020
- uses: actions/checkout@v5
2121
- uses: actions/setup-node@v5
2222
with:
23-
node-version: 22
23+
node-version: '22'
2424
cache: 'npm'
2525
- run: npm ci
2626
- run: npx abaplint ./abaplint.jsonc

.github/workflows/rename_test.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ jobs:
2020
- uses: actions/checkout@v5
2121
- uses: actions/setup-node@v5
2222
with:
23-
node-version: 22
23+
node-version: '22'
2424
cache: 'npm'
2525
- run: npm ci
2626
- run: npm run rename

.gitignore

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,5 @@
11
node_modules
2+
output
3+
.github/out/
4+
.github/abaplint/output/
5+
.github/abaplint/rename_run.json

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,4 +41,4 @@ This is a developer tool. It runs the SQL the user enters, without an authorizat
4141
<img width="700" alt="image" src="https://github.com/abap2UI5-addons/sql-console/assets/102328295/0be2bb38-d68a-475c-910a-b341757e5862">
4242

4343
#### Contribution & Support
44-
Pull Requests are welcome! Whether you're fixing a bug, adding new functionality, or improving the documentation, your contributions are always appreciated. If you run into problems, feel free to open an issue.
44+
Pull requests are welcome! Whether you're fixing bugs, adding new functionality, or improving documentation, your contributions are highly appreciated. If you encounter any issues, feel free to open an issue.

package.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,5 +17,8 @@
1717
"homepage": "https://github.com/abap2UI5-addons/sql-console#readme",
1818
"devDependencies": {
1919
"@abaplint/cli": "^2.119.14"
20+
},
21+
"engines": {
22+
"node": ">=22"
2023
}
2124
}

src/abap/z2ui5_sql_cl_app_01.clas.abap

Lines changed: 2 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,6 @@ CLASS z2ui5_sql_cl_app_01 DEFINITION PUBLIC.
108108

109109
METHODS history_db_read.
110110
METHODS preview_filter_search.
111-
METHODS preview_filter_range.
112111
METHODS history_on_clear_pressed.
113112
METHODS z2ui5_on_callback.
114113
METHODS z2ui5_on_event.
@@ -132,10 +131,8 @@ CLASS z2ui5_sql_cl_app_01 DEFINITION PUBLIC.
132131

133132
METHODS result_display
134133
IMPORTING
135-
fw_table TYPE string
136134
fo_result TYPE REF TO data
137-
ft_fieldlist TYPE z2ui5_sql_cl_query=>ty_t_fieldlist
138-
fw_title TYPE string.
135+
ft_fieldlist TYPE z2ui5_sql_cl_query=>ty_t_fieldlist.
139136

140137
PRIVATE SECTION.
141138

@@ -284,21 +281,6 @@ CLASS z2ui5_sql_cl_app_01 IMPLEMENTATION.
284281
ENDMETHOD.
285282

286283

287-
METHOD preview_filter_range.
288-
289-
FIELD-SYMBOLS <tab> TYPE STANDARD TABLE.
290-
ASSIGN ms_draft-s_preview-tab->* TO <tab>.
291-
292-
LOOP AT ms_draft-s_preview-t_filter INTO DATA(ls_tab).
293-
294-
DATA(lv_clause) = ls_tab-name && ` not in ls_tab-t_range`.
295-
DELETE <tab> WHERE (lv_clause).
296-
297-
ENDLOOP.
298-
299-
ENDMETHOD.
300-
301-
302284
METHOD preview_filter_search.
303285

304286
FIELD-SYMBOLS <tab> TYPE STANDARD TABLE.
@@ -475,10 +457,8 @@ CLASS z2ui5_sql_cl_app_01 IMPLEMENTATION.
475457
ms_draft-sql_s_command-name = ls_result-tabname.
476458

477459
result_display(
478-
fw_table = ls_result-from
479460
fo_result = ls_result-data
480461
ft_fieldlist = ls_result-fieldlist
481-
fw_title = ls_result-query
482462
).
483463

484464
ENDMETHOD.
@@ -615,7 +595,7 @@ CLASS z2ui5_sql_cl_app_01 IMPLEMENTATION.
615595

616596
METHOD z2ui5_on_init_set_app.
617597

618-
ms_draft-sql_input = `Select * from T100`.
598+
ms_draft-sql_input = `SELECT * FROM t100`.
619599
ms_draft-history_cont_size = `30%`.
620600
ms_draft-sql_cont_size = `auto`.
621601
ms_draft-s_preview-cont_size = `auto`.

src/abap/z2ui5_sql_cl_history_api.clas.abap

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ CLASS z2ui5_sql_cl_history_api DEFINITION
3232

3333
CLASS-METHODS db_read_by_id
3434
IMPORTING
35-
val TYPE clike DEFAULT sy-uname
35+
val TYPE clike
3636
RETURNING
3737
VALUE(result) TYPE ty_s_entry.
3838

0 commit comments

Comments
 (0)