Skip to content

Commit 15e1f6f

Browse files
authored
Merge pull request #7 from abap2UI5-addons/claude/abap2ui5-popup-usage-plpspy
Rename popup classes to use consistent naming convention
2 parents 4508162 + 25027ff commit 15e1f6f

5 files changed

Lines changed: 15 additions & 9 deletions

File tree

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ _Supported Formats: JSON, CSV, XLSX..._
1414

1515
#### Dependencies
1616
* [abap2UI5](https://github.com/abap2UI5/abap2UI5)
17+
* [popups](https://github.com/abap2UI5-addons/popups)
1718
* [abap2xlsx](https://github.com/abap2xlsx/abap2xlsx)
1819

1920
#### Limitations & Todo

abaplint.jsonc

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,11 @@
1313
"folder": "/abap2UI5",
1414
"files": "/src/**/*.*"
1515
},
16+
{
17+
"url": "https://github.com/abap2UI5-addons/popups",
18+
"folder": "/popups",
19+
"files": "/src/**/*.*"
20+
},
1621
{
1722
"url": "https://github.com/abap2xlsx/abap2xlsx",
1823
"folder": "/abap2xlsx",

src/z2ui5_cl_tcl_app_01.clas.abap

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ CLASS Z2UI5_CL_TCL_APP_01 IMPLEMENTATION.
4848

4949
IF client->get( )-check_on_navigated = abap_true.
5050
TRY.
51-
DATA(lo_popup_file) = CAST z2ui5_cl_pop_file_ul( client->get_app( client->get( )-s_draft-id_prev_app ) ).
51+
DATA(lo_popup_file) = CAST z2ui5_cl_popup_file_ul( client->get_app( client->get( )-s_draft-id_prev_app ) ).
5252
IF lo_popup_file->result( )-check_confirmed = abap_true.
5353
ms_app-file = lo_popup_file->result( )-value.
5454
client->message_toast_display( `File uploaded successfully` ).
@@ -59,7 +59,7 @@ CLASS Z2UI5_CL_TCL_APP_01 IMPLEMENTATION.
5959
CATCH cx_root.
6060
ENDTRY.
6161
TRY.
62-
DATA(lo_popup_confirm) = CAST z2ui5_cl_pop_to_confirm( client->get_app( client->get( )-s_draft-id_prev_app ) ).
62+
DATA(lo_popup_confirm) = CAST z2ui5_cl_popup_to_confirm( client->get_app( client->get( )-s_draft-id_prev_app ) ).
6363
IF lo_popup_confirm->result( ) = abap_true.
6464

6565
FIELD-SYMBOLS <tab2> TYPE STANDARD TABLE.
@@ -138,13 +138,13 @@ CLASS Z2UI5_CL_TCL_APP_01 IMPLEMENTATION.
138138
ENDIF.
139139
ENDLOOP.
140140

141-
client->nav_app_call( z2ui5_cl_pop_table=>factory( <tab2> ) ).
141+
client->nav_app_call( z2ui5_cl_popup_table=>factory( <tab2> ) ).
142142

143143
WHEN 'DB_SAVE'.
144-
client->nav_app_call( z2ui5_cl_pop_to_confirm=>factory( `Database will be deleted and new entries filled. Are you sure?` ) ).
144+
client->nav_app_call( z2ui5_cl_popup_to_confirm=>factory( `Database will be deleted and new entries filled. Are you sure?` ) ).
145145

146146
WHEN 'UPLOAD'.
147-
client->nav_app_call( z2ui5_cl_pop_file_ul=>factory( ) ).
147+
client->nav_app_call( z2ui5_cl_popup_file_ul=>factory( ) ).
148148

149149
WHEN 'BUTTON_CANCEL'.
150150
client->message_toast_display( |cancel| ).

src/z2ui5_cl_tcl_app_03.clas.abap

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -122,10 +122,10 @@ CLASS z2ui5_cl_tcl_app_03 IMPLEMENTATION.
122122
UP TO 10 ROWS.
123123

124124
DATA(lv_prev_json) = z2ui5_cl_util=>json_stringify( <tab2> ).
125-
client->nav_app_call( z2ui5_cl_pop_textedit=>factory( lv_prev_json ) ).
125+
client->nav_app_call( z2ui5_cl_popup_textedit=>factory( lv_prev_json ) ).
126126

127127
WHEN 'DOWNLOAD'.
128-
client->nav_app_call( z2ui5_cl_pop_file_dl=>factory( ms_app-file ) ).
128+
client->nav_app_call( z2ui5_cl_popup_file_dl=>factory( ms_app-file ) ).
129129

130130
WHEN 'BUTTON_CANCEL'.
131131
client->message_toast_display( |cancel| ).

src/z2ui5_cl_tcl_app_06.clas.abap

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ CLASS Z2UI5_CL_TCL_APP_06 IMPLEMENTATION.
123123

124124
TRY.
125125
DATA(lo_prev) = client->get_app( client->get( )-s_draft-id_prev_app ).
126-
ms_draft-table_name = CAST z2ui5_cl_pop_input_val( lo_prev )->result( )-value.
126+
ms_draft-table_name = CAST z2ui5_cl_popup_input_val( lo_prev )->result( )-value.
127127
ms_draft-check_load_pressed = abap_true.
128128

129129
ms_draft-t_tab = z2ui5_cl_util=>rtti_create_tab_by_name( ms_draft-table_name ).
@@ -235,7 +235,7 @@ CLASS Z2UI5_CL_TCL_APP_06 IMPLEMENTATION.
235235
set_view( ).
236236

237237
WHEN `NEW`.
238-
DATA(lo_app) = z2ui5_cl_pop_input_val=>factory(
238+
DATA(lo_app) = z2ui5_cl_popup_input_val=>factory(
239239
title = `Create a New XLSX Draft`
240240
text = `Database Table:`
241241
val = ms_draft-table_name ).

0 commit comments

Comments
 (0)