Merge pull request #5 from abap2UI5-addons/claude/abap-code-redundancies-z0mndd

Refactor to use utility methods for table creation and XLSX export

Author: oblomov-dev

src/01/z2ui5_cl_tcl_xlsx_api.clas.abap

@@ -17,6 +17,9 @@ CLASS z2ui5_cl_tcl_xlsx_api DEFINITION
     CLASS-METHODS get_xlsx_by_table
       IMPORTING
         val           TYPE any
+        title         TYPE clike DEFAULT `Internal table`
+        settings      TYPE ty_s_xlsx_settings OPTIONAL
+        fieldcatalog  TYPE ty_t_xlsx OPTIONAL
       RETURNING
         VALUE(result) TYPE xstring.
 
@@ -44,11 +47,17 @@ CLASS z2ui5_cl_tcl_xlsx_api IMPLEMENTATION.
 
     " Get active sheet
     lo_worksheet = lo_excel->get_active_worksheet( ).
-    lo_worksheet->set_title( 'Internal table' ).
+    lo_worksheet->set_title( CONV #( title ) ).
 
-    lt_field_catalog = zcl_excel_common=>get_fieldcatalog( ip_table = val ).
+    lt_field_catalog = fieldcatalog.
+    IF lt_field_catalog IS INITIAL.
+      lt_field_catalog = zcl_excel_common=>get_fieldcatalog( ip_table = val ).
+    ENDIF.
 
-    ls_table_settings-table_style  = zcl_excel_table=>builtinstyle_medium5.
+    ls_table_settings = settings.
+    IF ls_table_settings IS INITIAL.
+      ls_table_settings-table_style = zcl_excel_table=>builtinstyle_medium5.
+    ENDIF.
 
     lo_worksheet->bind_table( ip_table          = val
                               is_table_settings = ls_table_settings

src/z2ui5_cl_tcl_app_03.clas.abap

@@ -100,7 +100,7 @@ CLASS z2ui5_cl_tcl_app_03 IMPLEMENTATION.
 
         FIELD-SYMBOLS <tab2> TYPE STANDARD TABLE.
 
-        CREATE DATA mt_tab TYPE STANDARD TABLE OF (ms_app-db_table).
+        mt_tab = z2ui5_cl_util=>rtti_create_tab_by_name( ms_app-db_table ).
         ASSIGN mt_tab->* TO <tab2>.
 
         SELECT *
@@ -118,7 +118,7 @@ CLASS z2ui5_cl_tcl_app_03 IMPLEMENTATION.
 
       WHEN `PREVIEW`.
 
-        CREATE DATA mt_tab TYPE STANDARD TABLE OF (ms_app-db_table).
+        mt_tab = z2ui5_cl_util=>rtti_create_tab_by_name( ms_app-db_table ).
         ASSIGN mt_tab->* TO <tab2>.
 
         SELECT *

src/z2ui5_cl_tcl_app_04.clas.abap

@@ -44,11 +44,8 @@ CLASS Z2UI5_CL_TCL_APP_04 IMPLEMENTATION.
 
           WHEN 'UPLOAD'.
 
-            SPLIT mv_value AT `;` INTO DATA(lv_dummy) DATA(lv_data).
-            SPLIT lv_data AT `,` INTO lv_dummy lv_data.
-
-            DATA(lv_data2) = z2ui5_cl_util=>conv_decode_x_base64( lv_data ).
-            DATA(lv_ready) = z2ui5_cl_util=>conv_get_string_by_xstring( lv_data2 ).
+            DATA(lv_data) = z2ui5_cl_util=>conv_get_xstring_by_data_uri( mv_value ).
+            DATA(lv_ready) = z2ui5_cl_util=>conv_get_string_by_xstring( lv_data ).
 
             mr_table = z2ui5_cl_util=>itab_get_itab_by_csv( lv_ready ).
             client->message_box_display( `CSV loaded to table` ).

src/z2ui5_cl_tcl_app_05.clas.abap

@@ -41,10 +41,7 @@ CLASS Z2UI5_CL_TCL_APP_05 IMPLEMENTATION.
 
           WHEN 'UPLOAD'.
 
-            SPLIT mv_value AT `;` INTO DATA(lv_dummy) DATA(lv_data).
-            SPLIT lv_data AT `,` INTO lv_dummy lv_data.
-
-            DATA(lv_xdata) = z2ui5_cl_util=>conv_decode_x_base64( lv_data ).
+            DATA(lv_xdata) = z2ui5_cl_util=>conv_get_xstring_by_data_uri( mv_value ).
             mr_table = z2ui5_cl_tcl_xlsx_api=>get_table_by_xlsx( lv_xdata ).
             client->message_box_display( `XLSX loaded to table` ).
 

src/z2ui5_cl_tcl_app_06.clas.abap

@@ -70,8 +70,7 @@ CLASS Z2UI5_CL_TCL_APP_06 IMPLEMENTATION.
 
     TRY.
 
-        DATA lr_tab TYPE REF TO data.
-        CREATE DATA lr_tab TYPE STANDARD TABLE OF (ms_draft-table_name).
+        DATA(lr_tab) = z2ui5_cl_util=>rtti_create_tab_by_name( ms_draft-table_name ).
         FIELD-SYMBOLS <tab> TYPE table.
         ASSIGN lr_tab->* TO <tab>.
 
@@ -90,25 +89,10 @@ CLASS Z2UI5_CL_TCL_APP_06 IMPLEMENTATION.
 
         ENDIF.
 
-        DATA: lo_excel     TYPE REF TO zcl_excel,
-              lo_writer    TYPE REF TO zif_excel_writer,
-              lo_worksheet TYPE REF TO zcl_excel_worksheet.
-
-        " Creates active sheet
-        CREATE OBJECT lo_excel.
-
-        " Get active sheet
-        lo_worksheet = lo_excel->get_active_worksheet( ).
-        lo_worksheet->set_title( CONV #( ms_draft-t_config_head[ 1 ]-title ) ).
-
-        lo_worksheet->bind_table( ip_table          = <tab>
-                                  is_table_settings = ms_draft-t_config[ 1 ]
-                                  it_field_catalog  = ms_draft-t_fcat ).
-
-        lo_worksheet->freeze_panes( ip_num_rows = 1 ).
-
-        CREATE OBJECT lo_writer TYPE zcl_excel_writer_2007.
-        DATA(lv_result) = lo_writer->write_file( lo_excel ).
+        DATA(lv_result) = z2ui5_cl_tcl_xlsx_api=>get_xlsx_by_table( val          = <tab>
+                                                                    title        = ms_draft-t_config_head[ 1 ]-title
+                                                                    settings     = ms_draft-t_config[ 1 ]
+                                                                    fieldcatalog = ms_draft-t_fcat ).
         mv_file = z2ui5_cl_util=>conv_encode_x_base64( lv_result ).
 
         ms_draft-file_rows = lines( <tab> ).
@@ -142,7 +126,7 @@ CLASS Z2UI5_CL_TCL_APP_06 IMPLEMENTATION.
         ms_draft-table_name = CAST z2ui5_cl_pop_input_val( lo_prev )->result( )-value.
         ms_draft-check_load_pressed = abap_true.
 
-        CREATE DATA ms_draft-t_tab TYPE STANDARD TABLE OF (ms_draft-table_name).
+        ms_draft-t_tab = z2ui5_cl_util=>rtti_create_tab_by_name( ms_draft-table_name ).
         FIELD-SYMBOLS <tab> TYPE table.
         ASSIGN  ms_draft-t_tab->* TO <tab>.