Skip to content

Commit 2de1f88

Browse files
oblomov-devclaude
andauthored
Fix failing CI jobs: stale abaplint dependency branch and push to protected branch (#685)
- abaplint.jsonc / abap_cloud.jsonc: drop the abap2UI5 dependency pin to claude/ui5-samples-ai-demokit-s5n5sg — the branch was merged into main and deleted, so every lint job failed cloning it. Fall back to the default branch (main), which now contains the merged changes. - generate_overview_apps: standard is a protected branch (PRs only), so the auto-commit push was rejected on every run. Convert the job into a guard that regenerates the overview apps and fails on any diff; contributors regenerate in their PR per AGENTS.md §4. - README: remove the last-run stamp the workflow no longer maintains. Claude-Session: https://claude.ai/code/session_01A6f6qCjKEK3syioCzisYqD Co-authored-by: Claude <noreply@anthropic.com>
1 parent 5a72fe8 commit 2de1f88

4 files changed

Lines changed: 15 additions & 20 deletions

File tree

.github/abaplint/abap_cloud.jsonc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
},
1111
{
1212
"url": "https://github.com/abap2UI5/abap2UI5",
13-
"branch": "claude/ui5-samples-ai-demokit-s5n5sg",
1413
"folder": "/abap2UI5",
1514
"files": "/src/**/*.*"
1615
}
Lines changed: 15 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,25 @@
11
name: generate_overview_apps
22

3+
# Guards that the two overview apps (get_catalog) are in sync with the folder
4+
# tree: regenerates them and fails on any diff. standard is a protected branch
5+
# (changes only via pull request), so CI cannot push fixes back — contributors
6+
# regenerate the catalogs in their PR instead (see AGENTS.md §4).
7+
38
on:
9+
pull_request:
410
push:
511
branches: [standard]
612
workflow_dispatch:
713

814
permissions:
9-
contents: write
15+
contents: read
16+
17+
concurrency:
18+
group: generate_overview_apps-${{ github.ref }}
19+
cancel-in-progress: true
1020

1121
jobs:
1222
generate_overview_apps:
13-
if: github.ref == 'refs/heads/standard'
1423
runs-on: ubuntu-latest
1524
timeout-minutes: 10
1625
steps:
@@ -26,19 +35,9 @@ jobs:
2635
- run: npm ci
2736
- run: npm run launchpad
2837

29-
- name: Stamp last run date into README
30-
run: |
31-
STAMP=$(date -u '+%Y-%m-%d %H:%M UTC')
32-
sed -i "s|<!-- last-run -->.*<!-- /last-run -->|<!-- last-run -->$STAMP<!-- /last-run -->|" README.md
33-
34-
- name: Commit and push changes
38+
- name: Verify overview apps are up to date
3539
run: |
36-
git config user.name 'github-actions[bot]'
37-
git config user.email 'github-actions[bot]@users.noreply.github.com'
38-
git add src README.md
39-
if git diff --staged --quiet; then
40-
echo "No changes to commit."
41-
else
42-
git commit -m "Regenerate overview apps"
43-
git push origin HEAD:standard
40+
if ! git diff --exit-code -- src; then
41+
echo "::error::Overview apps are out of date. Run 'npm run launchpad' and commit the result (see AGENTS.md §4)."
42+
exit 1
4443
fi

README.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,6 @@ Install this repository and try out over 350 samples. This is the easiest way to
1616

1717
[![generate_overview_apps](https://github.com/abap2UI5/samples/actions/workflows/generate_overview_apps.yaml/badge.svg)](https://github.com/abap2UI5/samples/actions/workflows/generate_overview_apps.yaml)
1818

19-
_generate_overview_apps last run: <!-- last-run -->2026-07-17 08:36 UTC<!-- /last-run -->_
20-
2119
#### Dependencies
2220
* [abap2UI5](https://github.com/abap2UI5/abap2UI5)
2321

abaplint.jsonc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
},
1414
{
1515
"url": "https://github.com/abap2UI5/abap2UI5",
16-
"branch": "claude/ui5-samples-ai-demokit-s5n5sg",
1716
"folder": "/abap2UI5",
1817
"files": "/src/**/*.*"
1918
}

0 commit comments

Comments
 (0)