Make overview app generation a CI check instead of auto-commit - #685
Merged
Conversation
…tected branch - abaplint.jsonc / abap_cloud.jsonc: drop the abap2UI5 dependency pin to claude/ui5-samples-ai-demokit-s5n5sg — the branch was merged into main and deleted, so every lint job failed cloning it. Fall back to the default branch (main), which now contains the merged changes. - generate_overview_apps: standard is a protected branch (PRs only), so the auto-commit push was rejected on every run. Convert the job into a guard that regenerates the overview apps and fails on any diff; contributors regenerate in their PR per AGENTS.md §4. - README: remove the last-run stamp the workflow no longer maintains. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01A6f6qCjKEK3syioCzisYqD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes the
generate_overview_appsworkflow from automatically committing generated files to thestandardbranch into a CI check that verifies the overview apps are up to date. Contributors must now regenerate and commit the catalogs themselves as part of their pull requests.Key Changes
pull_requesttrigger alongside existingpushtostandardbranchcontents: writetocontents: read(no longer pushes commits)if: github.ref == 'refs/heads/standard'to run on all triggerssrc/has uncommitted changes after regeneration.github/abaplint/abap_cloud.jsoncandabaplint.jsoncImplementation Details
The workflow now:
npm run launchpadsrc/has any differencesThis enforces the protected branch model where
standardcannot receive direct commits from CI, ensuring all changes go through pull request review.https://claude.ai/code/session_01A6f6qCjKEK3syioCzisYqD