From cc846c0e214b23f667ed8c1e8da17432d2db03ba Mon Sep 17 00:00:00 2001 From: Claude Date: Sun, 19 Jul 2026 16:59:57 +0000 Subject: [PATCH] Fix failing CI jobs: stale abaplint dependency branch and push to protected branch MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - abaplint.jsonc / abap_cloud.jsonc: drop the abap2UI5 dependency pin to claude/ui5-samples-ai-demokit-s5n5sg — the branch was merged into main and deleted, so every lint job failed cloning it. Fall back to the default branch (main), which now contains the merged changes. - generate_overview_apps: standard is a protected branch (PRs only), so the auto-commit push was rejected on every run. Convert the job into a guard that regenerates the overview apps and fails on any diff; contributors regenerate in their PR per AGENTS.md §4. - README: remove the last-run stamp the workflow no longer maintains. Co-Authored-By: Claude Fable 5 Claude-Session: https://claude.ai/code/session_01A6f6qCjKEK3syioCzisYqD --- .github/abaplint/abap_cloud.jsonc | 1 - .github/workflows/generate_overview_apps.yaml | 31 +++++++++---------- README.md | 2 -- abaplint.jsonc | 1 - 4 files changed, 15 insertions(+), 20 deletions(-) diff --git a/.github/abaplint/abap_cloud.jsonc b/.github/abaplint/abap_cloud.jsonc index f5ecdda2f..1f3cdb212 100644 --- a/.github/abaplint/abap_cloud.jsonc +++ b/.github/abaplint/abap_cloud.jsonc @@ -10,7 +10,6 @@ }, { "url": "https://github.com/abap2UI5/abap2UI5", - "branch": "claude/ui5-samples-ai-demokit-s5n5sg", "folder": "/abap2UI5", "files": "/src/**/*.*" } diff --git a/.github/workflows/generate_overview_apps.yaml b/.github/workflows/generate_overview_apps.yaml index 36ecd34c1..b14f013e4 100644 --- a/.github/workflows/generate_overview_apps.yaml +++ b/.github/workflows/generate_overview_apps.yaml @@ -1,16 +1,25 @@ name: generate_overview_apps +# Guards that the two overview apps (get_catalog) are in sync with the folder +# tree: regenerates them and fails on any diff. standard is a protected branch +# (changes only via pull request), so CI cannot push fixes back — contributors +# regenerate the catalogs in their PR instead (see AGENTS.md §4). + on: + pull_request: push: branches: [standard] workflow_dispatch: permissions: - contents: write + contents: read + +concurrency: + group: generate_overview_apps-${{ github.ref }} + cancel-in-progress: true jobs: generate_overview_apps: - if: github.ref == 'refs/heads/standard' runs-on: ubuntu-latest timeout-minutes: 10 steps: @@ -26,19 +35,9 @@ jobs: - run: npm ci - run: npm run launchpad - - name: Stamp last run date into README - run: | - STAMP=$(date -u '+%Y-%m-%d %H:%M UTC') - sed -i "s|.*|$STAMP|" README.md - - - name: Commit and push changes + - name: Verify overview apps are up to date run: | - git config user.name 'github-actions[bot]' - git config user.email 'github-actions[bot]@users.noreply.github.com' - git add src README.md - if git diff --staged --quiet; then - echo "No changes to commit." - else - git commit -m "Regenerate overview apps" - git push origin HEAD:standard + if ! git diff --exit-code -- src; then + echo "::error::Overview apps are out of date. Run 'npm run launchpad' and commit the result (see AGENTS.md §4)." + exit 1 fi diff --git a/README.md b/README.md index 4eb9603ef..559b9864c 100644 --- a/README.md +++ b/README.md @@ -16,8 +16,6 @@ Install this repository and try out over 350 samples. This is the easiest way to [![generate_overview_apps](https://github.com/abap2UI5/samples/actions/workflows/generate_overview_apps.yaml/badge.svg)](https://github.com/abap2UI5/samples/actions/workflows/generate_overview_apps.yaml) -_generate_overview_apps last run: 2026-07-17 08:36 UTC_ - #### Dependencies * [abap2UI5](https://github.com/abap2UI5/abap2UI5) diff --git a/abaplint.jsonc b/abaplint.jsonc index 1058869e4..420261b46 100644 --- a/abaplint.jsonc +++ b/abaplint.jsonc @@ -13,7 +13,6 @@ }, { "url": "https://github.com/abap2UI5/abap2UI5", - "branch": "claude/ui5-samples-ai-demokit-s5n5sg", "folder": "/abap2UI5", "files": "/src/**/*.*" }