Add renaming smoke test and fix broken README badge - #689
Merged
Conversation
The README linked a 'renaming' badge to a non-existent rename_test.yaml workflow, so the badge never rendered. The samples repo had no renaming check at all. Add the missing renaming function, mirroring the abap2UI5 framework repo: - .github/workflows/test_rename.yaml runs it on every pull request - npm run rename runs abaplint --rename with the checked-in config - .github/abaplint/rename_test.jsonc renames the z2ui5 namespace to a placeholder and syntax-checks the result, scoped to the portable src/01 set (basic samples plus the abap2UI5 framework dependency) Point the README badge at the real workflow file (test_rename.yaml), matching the framework repo's naming. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014F3nMzDVeUx9vcz97797hw
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://claude.ai/code/session_014F3nMzDVeUx9vcz97797hw