Replace nest_view_model_update with view_model_update - #691
Merged
Conversation
The main and nested views now share one root model (nested views inherit the main view's model via UI5 propagation), so refreshing the main model via view_model_update also refreshes the nested views. The nest-specific nest_view_model_update call is therefore redundant. - 065: switch the demo call, button label and comment to view_model_update. - 097 / 098: replace the nest call; where it was already paired with a view_model_update, collapse the two into the single remaining call. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01F4VXychqy741rejPzYwLxy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consolidate model update logic by replacing all calls to
nest_view_model_update()withview_model_update(). This reflects the architectural change where main and nested views share a single model instance, making the separate nested update method redundant.Key Changes
nest_view_model_update()call withview_model_update()nest_view_model_update()withview_model_update()in ROW_DELETE handler; removed duplicatenest_view_model_update()call in SELCHANGE handlernest_view_model_update()calls in two event handlers, keeping onlyview_model_update()Implementation Details
The changes clarify that since the main and nested views now share a single view model, calling
view_model_update()automatically refreshes both views. This eliminates the need for a separate nested-specific update method and simplifies the API surface.https://claude.ai/code/session_01F4VXychqy741rejPzYwLxy