Move History sample (app 139) into package 99 (obsolete controls) - #692
Merged
Conversation
The history custom control is obsolete - app state in the URL is handled by the framework itself now (set_push_state). Park its demo alongside the other obsolete-custom-control samples in package 99. The class name is unchanged, so the app catalog (which references it by name) keeps working. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TVqCfSRD2jtvmokqV4x95w
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Moves the History demo (
z2ui5_cl_demo_app_139) from package00/07into package00/99, alongside the other obsolete-custom-control samples.Why
The
historycustom control rewrote the URL query string viahistory.replaceStatefrom a bound field. App state in the URL is handled by the framework itself now (set_push_state), so the control is obsolete — it was just marked as such in the framework view builder (z2ui5_cl_xml_view_cc). The app catalogg01already listed this demo under "experimental, TODO → History", so parking it in package 99 matches its existing standing.Notes
git mv), class name unchanged (z2ui5_cl_demo_app_139).🤖 Generated with Claude Code
Generated by Claude Code