Skip to content

Simplify control_by_id API: remove view parameter from t_arg #694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oblomov-dev merged 1 commit into from
Jul 22, 2026
Merged

Simplify control_by_id API: remove view parameter from t_arg #694

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/01/01/z2ui5_cl_demo_app_447.clas.abap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,17 +46,16 @@ CLASS z2ui5_cl_demo_app_447 IMPLEMENTATION.

CASE client->get( )-event.

" t_arg is positional: id, view (`` = global lookup), method, params
" t_arg is positional: id, method, params (the view defaults to
" cs_view-main and can be omitted for a main-view control)
WHEN `FOCUS`.
client->follow_up_action( val = z2ui5_if_client=>cs_event-control_by_id
t_arg = VALUE #( ( `nameInput` )
( `` )
( `focus` ) ) ).

WHEN `SCROLL`.
client->follow_up_action( val = z2ui5_if_client=>cs_event-control_by_id
t_arg = VALUE #( ( `bigTable` )
( `` )
( `scrollToIndex` )
( `25` ) ) ).

Expand Down
2 changes: 1 addition & 1 deletion src/01/02/z2ui5_cl_demo_app_088.clas.abap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ CLASS z2ui5_cl_demo_app_088 IMPLEMENTATION.

page->icon_tab_header( selectedkey = client->_bind( mv_selected_key )
select = client->_event_client( val = client->cs_event-control_by_id
t_arg = VALUE #( ( `NavCon` ) ( `MAIN` ) ( `to` ) ( `${$parameters>/selectedKey}` ) ) )
t_arg = VALUE #( ( `NavCon` ) ( `to` ) ( `${$parameters>/selectedKey}` ) ) )
mode = `Inline`
)->items(
)->icon_tab_filter( key = `page1`
Expand Down
3 changes: 2 additions & 1 deletion src/01/02/z2ui5_cl_demo_app_170.clas.abap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,9 @@
)->content( ).

DATA(content) = dialog->icon_tab_bar( selectedkey = client->_bind( mv_selected_key )
select = client->_event_client( val = client->cs_event-control_by_id

Check failure on line 31 in src/01/02/z2ui5_cl_demo_app_170.clas.abap

View check run for this annotation

abaplint / abaplint

Method importing parameter "VIEW" does not exist 

https://rules.abaplint.org/check_syntax
t_arg = VALUE #( ( `NavCon` ) ( `POPUP` ) ( `to` ) ( `${$parameters>/selectedKey}` ) ) )
view = client->cs_view-popup
t_arg = VALUE #( ( `NavCon` ) ( `to` ) ( `${$parameters>/selectedKey}` ) ) )
headermode = `Inline`
expanded = abap_true
expandable = abap_false
Expand Down
7 changes: 4 additions & 3 deletions src/01/02/z2ui5_cl_demo_app_202.clas.abap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,13 +84,14 @@ CLASS Z2UI5_CL_DEMO_APP_202 IMPLEMENTATION.
WHEN `STEP22` OR `STEP23`.
" the original wizard flow (discardProgress + setNextStep) as two
" generic whitelisted control calls - t_arg is positional:
" id, view, method, params (the step params are control ids)
" id, method, params (the step params are control ids; the view
" defaults to cs_view-main)
client->follow_up_action(
val = z2ui5_if_client=>cs_event-control_by_id
t_arg = VALUE #( ( `wiz` ) ( `MAIN` ) ( `discardProgress` ) ( `STEP2` ) ) ).
t_arg = VALUE #( ( `wiz` ) ( `discardProgress` ) ( `STEP2` ) ) ).
client->follow_up_action(
val = z2ui5_if_client=>cs_event-control_by_id
t_arg = VALUE #( ( `STEP2` ) ( `MAIN` ) ( `setNextStep` ) ( client->get( )-event ) ) ).
t_arg = VALUE #( ( `STEP2` ) ( `setNextStep` ) ( client->get( )-event ) ) ).

ENDCASE.
client->view_model_update( ).
Expand Down
4 changes: 2 additions & 2 deletions src/01/02/z2ui5_cl_demo_app_448.clas.abap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,11 @@ CLASS z2ui5_cl_demo_app_448 IMPLEMENTATION.
WHEN `TOGGLE`.
" invert the mirrored state and call the whitelisted setExpanded on
" the panel - client-side, after the response renders, no rebuild.
" t_arg is positional: id, view (`` = global lookup), method, params
" t_arg is positional: id, method, params (the view defaults to
" cs_view-main and can be omitted for a main-view control)
expanded = xsdbool( expanded = abap_false ).
client->follow_up_action( val = z2ui5_if_client=>cs_event-control_by_id
t_arg = VALUE #( ( `demoPanel` )
( `` )
( `setExpanded` )
( CONV string( expanded ) ) ) ).

Expand Down
4 changes: 2 additions & 2 deletions src/01/02/z2ui5_cl_demo_app_449.clas.abap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,10 @@ CLASS z2ui5_cl_demo_app_449 IMPLEMENTATION.
WHEN `OPEN`.
" open the popup-mode PDFViewer via the whitelisted open method -
" the viewer brings its own dialog and close button.
" t_arg is positional: id, view (`` = global lookup), method
" t_arg is positional: id, method (the view defaults to cs_view-main
" and can be omitted for a main-view control)
client->follow_up_action( val = z2ui5_if_client=>cs_event-control_by_id
t_arg = VALUE #( ( `demoPdf` )
( `` )
( `open` ) ) ).

ENDCASE.
Expand Down
4 changes: 2 additions & 2 deletions src/01/02/z2ui5_cl_demo_app_465.clas.abap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,10 @@ CLASS z2ui5_cl_demo_app_465 IMPLEMENTATION.
" toggle the popover open/closed, anchored to the pressed button's DOM
" ref - the whitelisted toggleBy opens it if closed, closes it if open
" (the controller pattern oPopover.openBy(oButton) / oPopover.close()).
" t_arg is positional: id, view (`` = global lookup), method, anchor id
" t_arg is positional: id, method, anchor id (the view defaults to
" cs_view-main and can be omitted for a main-view control)
client->follow_up_action( val = z2ui5_if_client=>cs_event-control_by_id
t_arg = VALUE #( ( `demoPopover` )
( `` )
( `toggleBy` )
( client->get_event_arg( ) ) ) ).

Expand Down
Loading